Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Remove containerized check from setuid logic #37794

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[Heartbeat] Remove containerized check from setuid logic #37794

merged 2 commits into from
Jan 31, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Jan 30, 2024 •
edited
Loading

Proposed commit message

Removed isContainerized from setuid check, as it fails to detect containers running under cgroups v2 and prevents switching users when running as root.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@emilioalvap emilioalvap added bug v8.11.0 backport-v8.11.0 Automated backport with mergify labels Jan 30, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner January 30, 2024 19:07
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 30, 2024
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-30T19:07:35.618+0000

  • Duration: 6 min 1 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

vigneshshanmugam
vigneshshanmugam approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

heartbeat/security/security.go Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 49 min 59 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Jan 31, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2024
@emilioalvap emilioalvap merged commit 5d1c592 into elastic:main Jan 31, 2024
33 checks passed
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@emilioalvap @mergify
[Heartbeat] Remove containerized check from setuid logic (#37794)
c35ce5e 
Removed isContainerized from setuid check, as it fails to detect containers running under cgroups v2 and prevents switching users when running as root.

(cherry picked from commit 5d1c592)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Closed
@emilioalvap emilioalvap added the backport-v8.12.0 Automated backport with mergify label Jan 31, 2024
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@emilioalvap @mergify
[Heartbeat] Remove containerized check from setuid logic (#37794)
c692cde 
Removed isContainerized from setuid check, as it fails to detect containers running under cgroups v2 and prevents switching users when running as root.

(cherry picked from commit 5d1c592)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
emilioalvap added a commit that referenced this pull request Jan 31, 2024
@mergify @emilioalvap
[Heartbeat] Remove containerized check from setuid logic (#37794) (#3…
fe78ff5 
…7803)

Removed isContainerized from setuid check, as it fails to detect containers running under cgroups v2 and prevents switching users when running as root.

(cherry picked from commit 5d1c592)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@emilioalvap @Scholar-Li
[Heartbeat] Remove containerized check from setuid logic (elastic#37794)
36f8b1a 
Removed isContainerized from setuid check, as it fails to detect containers running under cgroups v2 and prevents switching users when running as root.
@emilioalvap emilioalvap mentioned this pull request Mar 14, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.11.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilioalvap @elasticmachine @vigneshshanmugam