Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable filesystem check for MacOS unit-tests #37687

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Temporarily disable filesystem check for MacOS unit-tests #37687

merged 6 commits into from
Jan 24, 2024

Conversation

sharbuz
Copy link
Contributor

@sharbuz sharbuz commented Jan 22, 2024 •
edited
Loading

What is the problem this PR solves?

Currently, macOS unit tests are not running at all, they just excluded from ci since the tests failed and they were migrated to GitHub Actions
During the Migration from Jenkins/GitHub Actions it will be recovered.
The issue was created: #37686
The tests were run: https://buildkite.com/elastic/beats-metricbeat/builds/1320#018d3097-c24c-428b-84e9-86a5da0be422/431
PR: #37592

This PR is a blocker for #37592

Temporarily disable filesystem check for MacOS unit-tests because of filesystem check issue

How does this PR solve the problem?

Temporarily disable filesystem check for MacOS unit-tests because of filesystem check issue

Related issues

#37686

@sharbuz sharbuz added macOS Enable builds in the CI for darwin testing backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify labels Jan 22, 2024
@sharbuz sharbuz requested a review from a team as a code owner January 22, 2024 12:58
@sharbuz sharbuz requested review from ycombinator and faec January 22, 2024 12:58
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 22, 2024
@sharbuz sharbuz mentioned this pull request Jan 22, 2024
Open
@sharbuz sharbuz changed the title temporary desable filesystem check for MacOS unit-tests Temporarily disable filesystem check for MacOS unit-tests Jan 22, 2024
@sharbuz sharbuz requested review from v1v and pazone January 22, 2024 13:00
@sharbuz sharbuz added the Team:Elastic-Agent Label for the Agent team label Jan 22, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 22, 2024
@sharbuz sharbuz requested a review from jlind23 January 22, 2024 16:03
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Duration: 362 min 17 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Collaborator

Do we have a followup issue to re-enable this in the future?

@sharbuz
Copy link
Contributor Author

sharbuz commented Jan 23, 2024 •
edited
Loading

Do we have a followup issue to re-enable this in the future?

@pierrehilbert, I've updated the issue description with the task for enabling the test after fixing the issue.

@sharbuz sharbuz enabled auto-merge (squash) January 23, 2024 12:17
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Duration: 335 min 25 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-23T14:12:08.373+0000

  • Duration: 100 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 4609
Skipped 918
Total 5527

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-23T15:46:55.199+0000

  • Duration: 362 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 4609
Skipped 918
Total 5527

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Collaborator

As the issue is related to our MacOS runner, I'm forcing the merge to unlock this PR.

@pierrehilbert pierrehilbert merged commit 3bf2a82 into elastic:main Jan 24, 2024
32 of 33 checks passed
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
@sharbuz @mergify
temporary desable filesystem check for MacOS unit-tests (#37687)
7c3bf8f 
(cherry picked from commit 3bf2a82)

# Conflicts:
#	metricbeat/module/system/test_system.py
@mergify mergify bot mentioned this pull request Jan 24, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 24, 2024
@sharbuz @mergify
temporary desable filesystem check for MacOS unit-tests (#37687)
e738443 
(cherry picked from commit 3bf2a82)
@mergify mergify bot mentioned this pull request Jan 24, 2024
Merged
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-24T08:31:44.851+0000

  • Duration: 362 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 4609
Skipped 918
Total 5527

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

pierrehilbert added a commit that referenced this pull request Jan 29, 2024
@mergify @sharbuz @pierrehilbert
temporary desable filesystem check for MacOS unit-tests (#37687) (#37722
cd8b58d 
)

(cherry picked from commit 3bf2a82)

Co-authored-by: sharbuz <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@sharbuz @Scholar-Li
temporary desable filesystem check for MacOS unit-tests (elastic#37687)
9aeb8e5
sharbuz added a commit that referenced this pull request Feb 9, 2024
@mergify @sharbuz @pierrehilbert
[7.17](backport #37687) Temporarily disable filesystem check for MacO…
4e1d911 
…S unit-tests (#37721)

* temporary desable filesystem check for MacOS unit-tests (#37687)

(cherry picked from commit 3bf2a82)

# Conflicts:
#	metricbeat/module/system/test_system.py

* Update test_system.py

---------

Co-authored-by: sharbuz <[email protected]>
Co-authored-by: Pierre HILBERT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@v1v v1v Awaiting requested review from v1v

@pazone pazone Awaiting requested review from pazone

@jlind23 jlind23 Awaiting requested review from jlind23

Assignees

@sharbuz sharbuz

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify macOS Enable builds in the CI for darwin testing Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharbuz @elasticmachine @pierrehilbert