Remove convert old states code #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
Filebeat
5 tasks
tsg
reviewed
Mar 22, 2017
CHANGELOG.asciidoc
Outdated
| @@ -20,6 +20,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff] | |||
|
|
|||
| *Filebeat* | |||
| - Always use absolute path for event and registry. This can lead to issues when relative paths were used before. {pull}3328[3328] | |||
| - Remove code to convert states from 1.x. | |||
There was a problem hiding this comment.
Ah, still has in in progress, nevermind :)
There was a problem hiding this comment.
good you mentioned it, would have forgotten otherwise ;-)
Filebeat 1.x had a different registry format from 5.x. So a conversion of the format happened. This code is now removed for 6.0 as the upgrade path to 6.0 is from 5.0. The code caused some issues in the past so it is better to not have it in anymore.
ruflin
force-pushed
the
remove-convert-old-states
branch
from
f2a7f07 to
91fa70d
Compare
ruflin
added
review
and removed
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filebeat 1.x had a different registry format from 5.x. So a conversion of the format happened. This code is now removed for 6.0 as the upgrade path to 6.0 is from 5.0.
The code caused some issues in the past so it is better to not have it in anymore.