Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format log message correctly for heartbeat #37369

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

vigneshshanmugam
Copy link
Member

Summary

  • Fix the formatting of the logs on HB for project monitors.
Running %s in %s/usr/share/heartbeat/.node/node/bin/npm install --no-audit --no-update-notifier --no-fund --package-lock=false --progress=false/tmp/elastic-synthetics-unzip-4066455738

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@vigneshshanmugam vigneshshanmugam added Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0 v8.12.0 backport-v8.11.0 Automated backport with mergify labels Dec 8, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 8, 2023
@vigneshshanmugam vigneshshanmugam requested review from emilioalvap and andrewvc and removed request for emilioalvap December 8, 2023 19:07
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 54 min 40 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Collaborator

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@vigneshshanmugam vigneshshanmugam merged commit 157b31a into elastic:main Dec 11, 2023
@vigneshshanmugam vigneshshanmugam deleted the fix-hb-project-log branch December 11, 2023 16:01
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
vigneshshanmugam added a commit that referenced this pull request Dec 11, 2023
(cherry picked from commit 157b31a)

Co-authored-by: Vignesh Shanmugam <[email protected]>
@vigneshshanmugam vigneshshanmugam added the backport-v8.12.0 Automated backport with mergify label Dec 13, 2023
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
vigneshshanmugam added a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit 157b31a)

Co-authored-by: Vignesh Shanmugam <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants