-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filestream benchmarks for many files case, fix data race #37345
Conversation
Before it was only testing for a single file not the tests support many files. During test runs with the race detector a data race was found and fixed.
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
…#37345) Before it was only testing for a single file not the tests support many files. During test runs with the race detector a data race was found and fixed.
Before it was only testing for a single file not the tests support many files.
During test runs with the race detector a data race was found and fixed.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
This script will generate PDFs with CPU and memory profiles for each test case:
many-fp-cpu-profile.pdf
many-fp-mem-profile.pdf
many-inode-cpu-profile.pdf
many-inode-mem-profile.pdf
single-fp-cpu-profile.pdf
single-fp-mem-profile.pdf
single-inode-cpu-profile.pdf
single-inode-mem-profile.pdf
Related issues