-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS Fargate] Add memory hard limit from container metadata and remove usage percentage #37194
[AWS Fargate] Add memory hard limit from container metadata and remove usage percentage #37194
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This comment was marked as outdated.
This comment was marked as outdated.
d5344b0
to
e747537
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
CC: @agithomas @shmsr to planing the review once the PR is opened. |
4a52ebd
to
8a3e623
Compare
This comment was marked as outdated.
This comment was marked as outdated.
49e65da
to
ad0a9e8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4e73b12
to
4082276
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
e4dab69
to
e1d2e62
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…metricbeat_memory_limits
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@lucian-ioan you were able to get actual container limits while testing this with a custom built agent containing these changes, right? |
@gpop63 yes, tested multiple times and the memory limits line up with what I set in AWS. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
…e usage percentage (elastic#37194)
Proposed commit message
Add memory hard limit from container metadata and remove usage percentage.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Follow the AWS Fargate blogpost to create to set up the integration and create the resources.
Be sure that your resource has cmd execution rights, for example add
"enable-execute-command"
argument while creating the resource via the AWS CLI:Retrieve ECS_CONTAINER_METADATA_URI_V4 via
echo $ECS_CONTAINER_METADATA_URI_V4
.Fetch task data via
curl
:Related issues