x-pack/filebeat/input/cel: suppress and log max http request retry errors #37160

efd6 · 2023-11-21T00:35:18Z

Proposed commit message

The retryablehttp.Client will return an error based on the ErrorHandler field when the number of requests exceeds the maximum configuration. In the case that the field is nil, this is a non-nil error that causes issues with some APIs and does not allow the CEL code to evaluate the HTTP response status. So add a retryablehttp.ErrorHandler that will log the failure, but return the response unaltered and a nil error.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

This is arguably a bugfix, but marking as an enhancement in the first instance.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

…rors The retryablehttp.Client will return an error based on the ErrorHandler field when the number of requests exceeds the maximum configuration. In the case that the field is nil, this is a non-nil error that causes issues with some APIs and does not allow the CEL code to evaluate the HTTP response status. So add a retryablehttp.ErrorHandler that will log the failure, but return the response unaltered and a nil error.

elasticmachine · 2023-11-21T02:07:34Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-11-21T00:37:22.803+0000
Duration: 90 min 7 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2797
Skipped	176
Total	2973

Steps errors

Expand to view the steps failures

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-11-21T04:17:54Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 137 min 50 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-11-21T05:41:09Z

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

x-pack/filebeat/input/cel/input.go

elasticmachine · 2023-11-21T11:19:27Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-11-21T11:03:01.362+0000
Duration: 16 min 12 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3
Skipped	0
Total	3

Steps errors

Expand to view the steps failures

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-11-21T13:28:46Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 135 min 32 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-11-21T23:07:05Z

💚 Build Succeeded

Expand to view the summary

Build stats

Start Time: 2023-11-21T20:51:54.959+0000
Duration: 135 min 4 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3233
Skipped	176
Total	3409

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

bhapas

LGTM

elasticmachine · 2023-11-22T08:48:01Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-11-22T08:01:04.160+0000
Duration: 47 min 52 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2799
Skipped	176
Total	2975

Steps errors

Expand to view the steps failures

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-11-22T08:52:00Z

💚 Build Succeeded

Expand to view the summary

Build stats

Start Time: 2023-11-22T08:41:55.569+0000
Duration: 10 min 59 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…rors (elastic#37160) The retryablehttp.Client will return an error based on the ErrorHandler field when the number of requests exceeds the maximum configuration. In the case that the field is nil, this is a non-nil error that causes issues with some APIs and does not allow the CEL code to evaluate the HTTP response status. So add a retryablehttp.ErrorHandler that will log the failure, but return the response unaltered and a nil error.

efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.12-candidate labels Nov 21, 2023

efd6 self-assigned this Nov 21, 2023

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 21, 2023

efd6 force-pushed the cel_suppress_retry_errors branch from 03a26db to f2645b6 Compare November 21, 2023 00:37

efd6 changed the title ~~x-pack/filebeat/input/cel: uppress and log max http request retry errors~~ x-pack/filebeat/input/cel: suppress and log max http request retry errors Nov 21, 2023

efd6 force-pushed the cel_suppress_retry_errors branch from f2645b6 to a43bb96 Compare November 21, 2023 02:00

efd6 mentioned this pull request Nov 21, 2023

x-pack/filebeat/input/cel: do not request more work after an eval failure #37161

Merged

7 tasks

efd6 marked this pull request as ready for review November 21, 2023 05:41

efd6 requested a review from a team as a code owner November 21, 2023 05:41

bhapas reviewed Nov 21, 2023

View reviewed changes

x-pack/filebeat/input/cel/input.go Show resolved Hide resolved

bhapas reviewed Nov 21, 2023

View reviewed changes

x-pack/filebeat/input/cel/input.go Show resolved Hide resolved

efd6 force-pushed the cel_suppress_retry_errors branch from a2d8321 to f9beaa4 Compare November 21, 2023 11:11

add test

ed703fc

efd6 force-pushed the cel_suppress_retry_errors branch from f9beaa4 to ed703fc Compare November 21, 2023 11:13

bhapas reviewed Nov 21, 2023

View reviewed changes

x-pack/filebeat/input/cel/input.go Show resolved Hide resolved

for avoidance of doubt

15621fe

bhapas approved these changes Nov 22, 2023

View reviewed changes

efd6 force-pushed the cel_suppress_retry_errors branch from b08727c to 15621fe Compare November 22, 2023 08:41

efd6 merged commit cc39376 into elastic:main Nov 22, 2023
24 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x-pack/filebeat/input/cel: suppress and log max http request retry errors #37160

x-pack/filebeat/input/cel: suppress and log max http request retry errors #37160

efd6 commented Nov 21, 2023 •

edited

Loading

elasticmachine commented Nov 21, 2023

Build stats

Test stats 🧪

`Error signal`

elasticmachine commented Nov 21, 2023

Build stats

elasticmachine commented Nov 21, 2023

elasticmachine commented Nov 21, 2023

Build stats

Test stats 🧪

`Error signal`

elasticmachine commented Nov 21, 2023

Build stats

elasticmachine commented Nov 21, 2023

Build stats

Test stats 🧪

bhapas left a comment

elasticmachine commented Nov 22, 2023

Build stats

Test stats 🧪

`Error signal`

elasticmachine commented Nov 22, 2023

Build stats

x-pack/filebeat/input/cel: suppress and log max http request retry errors #37160

x-pack/filebeat/input/cel: suppress and log max http request retry errors #37160

Conversation

efd6 commented Nov 21, 2023 • edited Loading

Proposed commit message

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

elasticmachine commented Nov 21, 2023

❕ Build Aborted

Build stats

Test stats 🧪

Steps errors

Error signal

🤖 GitHub comments

elasticmachine commented Nov 21, 2023

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

elasticmachine commented Nov 21, 2023

elasticmachine commented Nov 21, 2023

❕ Build Aborted

Build stats

Test stats 🧪

Steps errors

Error signal

🤖 GitHub comments

elasticmachine commented Nov 21, 2023

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

elasticmachine commented Nov 21, 2023

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

bhapas left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 22, 2023

❕ Build Aborted

Build stats

Test stats 🧪

Steps errors

Error signal

🤖 GitHub comments

elasticmachine commented Nov 22, 2023

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

efd6 commented Nov 21, 2023 •

edited

Loading

`Error signal`

`Error signal`

`Error signal`