Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11](backport #37077) Fix memqueue getting stuck on shutdown #37100

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 13, 2023

This is an automatic backport of pull request #37077 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

There was a case when openState.publish could get stuck and ignore its
shutdown signal, effectively preventing a Filebeat (or any Beat) from
gracefully terminating.

This commit fixes this by ensuring every channel read/write also
checks for the shutdown signal.

(cherry picked from commit a473880)
@mergify mergify bot requested a review from a team as a code owner November 13, 2023 10:16
@mergify mergify bot removed the request for review from a team November 13, 2023 10:16
@mergify mergify bot added the backport label Nov 13, 2023
@mergify mergify bot requested review from belimawr and leehinman November 13, 2023 10:16
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 13, 2023
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 13, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 13, 2023
@pierrehilbert pierrehilbert removed the request for review from leehinman November 13, 2023 11:09
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-15T09:46:41.884+0000

  • Duration: 71 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 28469
Skipped 2013
Total 30482

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@belimawr belimawr merged commit 7ace47d into 8.11 Nov 16, 2023
87 checks passed
@belimawr belimawr deleted the mergify/bp/8.11/pr-37077 branch November 16, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants