x-pack/filebeat/input/cel: log transaction ID in CEL evaluations #37065
Conversation
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
efd6
force-pushed
the
cel_tracing_correlation
branch
from
1925fda to
6bd5182
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Emit a previous transaction ID before starting CEL evaluation and the final ID after completing the work. Also write transaction IDs to CEL debug log call if available.
efd6
force-pushed
the
cel_tracing_correlation
branch
from
6bd5182 to
c018dec
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
| @@ -167,6 +167,15 @@ func (rt *LoggingRoundTripper) RoundTrip(req *http.Request) (*http.Response, err | |||
| return resp, err | |||
| } | |||
|
|
|||
| // TxID returns the current transaction.id value. If rt is nil, the empty string is returned. | |||
| func (rt *LoggingRoundTripper) TxID() string { | |||
There was a problem hiding this comment.
Possible to add test cases for this func?
There was a problem hiding this comment.
What failure modes are you expecting that can't be proven safe by inspection?
There was a problem hiding this comment.
Not just about failure scenarios. There is a specific format that is being returned here, so just thought if it is covered in a test to guard against unsafe changes in future. But you can take a call here. This might not change often or at all.
There was a problem hiding this comment.
I think I'm OK with what we have; the two places that return a transaction ID are within 10 lines of each other and are very clearly related. I did think about making them tied, but didn't see a good way to do it. I have that now, so I'll make that change.
…stic#37065) Emit a previous transaction ID before starting CEL evaluation and the final ID after completing the work. Also write transaction IDs to CEL debug log call if available.
Proposed commit message
Emit a previous transaction ID before starting CEL evaluation and the final ID after completing the work. Also write transaction IDs to CEL debug log call if available.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Run
go test -v -run TestInput/tracer_filename_sanitizationin the cel package to see transaction IDs in the log.Related issues
Use cases
Screenshots
Logs