Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs - Clarify how to use 'certificate' for servers #36991

Merged
merged 1 commit into from
Oct 31, 2023
Merged

docs - Clarify how to use 'certificate' for servers #36991

merged 1 commit into from
Oct 31, 2023

Conversation

andrewkroh
Copy link
Member

Proposed commit message

The docs didn't show where to put issuer certificate in the context of TLS servers. This explains how to build up a PEM certificate bundle

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh
docs - Clarify how to use 'certificate' for servers
8117667 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 8 min 28 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh marked this pull request as ready for review October 30, 2023 20:11
@andrewkroh andrewkroh requested a review from a team as a code owner October 30, 2023 20:11
@andrewkroh andrewkroh added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 30, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2023
@andrewkroh andrewkroh added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.11.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify labels Oct 30, 2023
@nimarezainia nimarezainia requested a review from kilfoyle October 31, 2023 00:09
kilfoyle
kilfoyle approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewkroh andrewkroh merged commit 009b3f0 into elastic:main Oct 31, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@andrewkroh @mergify
docs - Clarify how to use 'certificate' for servers (#36991)
07fcd24 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle

(cherry picked from commit 009b3f0)
@mergify mergify bot mentioned this pull request Oct 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@andrewkroh @mergify
docs - Clarify how to use 'certificate' for servers (#36991)
ca6ffc7 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle

(cherry picked from commit 009b3f0)
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@andrewkroh @mergify
docs - Clarify how to use 'certificate' for servers (#36991)
c28e596 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle

(cherry picked from commit 009b3f0)
This was referenced Oct 31, 2023
Merged
Merged
andrewkroh added a commit that referenced this pull request Oct 31, 2023
@mergify @andrewkroh
docs - Clarify how to use 'certificate' for servers (#36991) (#37004)
bf6dde1 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle

(cherry picked from commit 009b3f0)

Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh added a commit that referenced this pull request Oct 31, 2023
@mergify @andrewkroh
docs - Clarify how to use 'certificate' for servers (#36991) (#37005)
b284105 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle

(cherry picked from commit 009b3f0)

Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh added a commit that referenced this pull request Oct 31, 2023
@mergify @andrewkroh
docs - Clarify how to use 'certificate' for servers (#36991) (#37006)
28eca91 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle

(cherry picked from commit 009b3f0)

Co-authored-by: Andrew Kroh <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@andrewkroh @Scholar-Li
docs - Clarify how to use 'certificate' for servers (elastic#36991)
fb5498f 
The docs didn't show where to put issuer certificate in the context
of TLS servers. This explains how to build up a PEM certificate bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@cmacknz cmacknz cmacknz approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@andrewkroh andrewkroh

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify docs libbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewkroh @elasticmachine @cmacknz @kilfoyle