-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to elastic-agent-libs v0.6.2. #36969
Conversation
Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix.
/test x-pack/filebeat-pythonIntegTest |
This commit is causing It is reporting the following differences:
My suspicion is the that it must be the golang.org/x/net update, so looking at the commits between releases golang/net@v0.12.0...v0.17.0 nothing immediately jumped out. Looking at the squid module configuration I can see it makes heavy use of the registered_domain processor:
This processor does indeed depend directly on golang.org/x/net module that was changed between released:
Specifically I believe it is golang/net@1e23797 which updates the public domain table in the publicsuffix table. That commit is mostly a set of large binary files but in the tests I see they are adding cases for akamai domains and several of the changes look similar to what I am observing here. I am going to update the test data and add a changelog entry noting this. |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this whitespace change expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, my editor must have added that automatically on save. Will remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has led me down a rabbit whole because both vim and VSCode are adding a trailing newline on save and won't let me remove it. I am just going to leave this here as long as the test passes rather than trying to find which editor configuration lets me remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an entry in .editorconfig that enforces trailing newlines. This is almost always correct, but not with expected test outcome JSON files. I turn off editorconfig awareness in the editor I use because of this.
* Update to elastic-agent-libs v0.6.2. Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix. * Add changelog entry. * Updates for latest version of golang.org/x/net/publicsuffix * Update all remaining subdomains (cherry picked from commit ae11b47) # Conflicts: # NOTICE.txt # go.mod # go.sum
* Update to elastic-agent-libs v0.6.2. Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix. * Add changelog entry. * Updates for latest version of golang.org/x/net/publicsuffix * Update all remaining subdomains (cherry picked from commit ae11b47) # Conflicts: # go.sum
* Update to elastic-agent-libs v0.6.2. (#36969) * Update to elastic-agent-libs v0.6.2. Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix. * Add changelog entry. * Updates for latest version of golang.org/x/net/publicsuffix * Update all remaining subdomains (cherry picked from commit ae11b47) # Conflicts: # go.sum * Resolve conflicts. * Remove extra entries in CHANGELOG.next.asciidoc --------- Co-authored-by: Craig MacKenzie <[email protected]>
* Update to elastic-agent-libs v0.6.2. (#36969) * Update to elastic-agent-libs v0.6.2. Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix. * Add changelog entry. * Updates for latest version of golang.org/x/net/publicsuffix * Update all remaining subdomains (cherry picked from commit ae11b47) # Conflicts: # NOTICE.txt # go.mod # go.sum * Resolve conflicts. * Remove extra entries in CHANGELOG.next.asciidoc --------- Co-authored-by: Craig MacKenzie <[email protected]>
* Update to elastic-agent-libs v0.6.2. Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix. * Add changelog entry. * Updates for latest version of golang.org/x/net/publicsuffix * Update all remaining subdomains
Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix.