Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Bump nodejs minor version #36961

Merged
merged 5 commits into from
Oct 31, 2023
Merged

[Heartbeat] Bump nodejs minor version #36961

merged 5 commits into from
Oct 31, 2023

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Oct 25, 2023 •
edited by vigneshshanmugam
Loading

Proposed commit message

Bump NodeJS version bundled with Heartbeat to 18.18.2.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Build mage package locally.
  2. Run a container with the generated image.
  3. Execute the following command and test version matches 18.17.1:
docker run --rm --entrypoint /bin/bash docker.elastic.co/beats/heartbeat:<version> -c "node --version"
v18.18.2

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0 backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 25, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner October 25, 2023 15:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 25, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 25, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 104 min 2 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

emilioalvap
emilioalvap commented Oct 25, 2023
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 25, 2023
pierrehilbert
pierrehilbert approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b hb-bump-node-minor upstream/hb-bump-node-minor
git merge upstream/main
git push upstream hb-bump-node-minor

belimawr
belimawr requested changes Oct 25, 2023
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@emilioalvap emilioalvap requested a review from belimawr October 26, 2023 15:21
@emilioalvap emilioalvap enabled auto-merge (squash) October 27, 2023 15:29
@emilioalvap emilioalvap removed the backport-v8.10.0 Automated backport with mergify label Oct 27, 2023
@emilioalvap
Copy link
Collaborator Author

@belimawr please review and unblock if OK

@emilioalvap emilioalvap merged commit 2539cdc into elastic:main Oct 31, 2023
7 checks passed
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@emilioalvap @mergify
[Heartbeat] Bump nodejs minor version (#36961)
f46d908 
Bump NodeJS version bundled with Heartbeat to 18.18.2.

Co-authored-by: Tiago Queiroz <[email protected]>

---------

Co-authored-by: Tiago Queiroz <[email protected]>
(cherry picked from commit 2539cdc)
@mergify mergify bot mentioned this pull request Oct 31, 2023
Merged
emilioalvap added a commit that referenced this pull request Nov 2, 2023
@mergify @emilioalvap
[Heartbeat] Bump nodejs minor version (#36961) (#37007)
496457d 
Bump NodeJS version bundled with Heartbeat to 18.18.2.

Co-authored-by: Tiago Queiroz <[email protected]>

---------

Co-authored-by: Tiago Queiroz <[email protected]>
(cherry picked from commit 2539cdc)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@emilioalvap @belimawr @Scholar-Li
[Heartbeat] Bump nodejs minor version (elastic#36961)
a78179a 
Bump NodeJS version bundled with Heartbeat to 18.18.2.

Co-authored-by: Tiago Queiroz <[email protected]>

---------

Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@belimawr belimawr belimawr approved these changes

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.11.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilioalvap @elasticmachine @belimawr @pierrehilbert @vigneshshanmugam