-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auditbeat/module - docs and comment nits #36952
Merged
andrewkroh
merged 3 commits into
elastic:main
from
andrewkroh:feature/ab/docs-comments-nits
Oct 26, 2023
Merged
auditbeat/module - docs and comment nits #36952
andrewkroh
merged 3 commits into
elastic:main
from
andrewkroh:feature/ab/docs-comments-nits
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 24, 2023
andrewkroh
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Oct 24, 2023
Really minor fixes to docs and comments in auditbeat/modules. As I was reading the code I was applying some changes, so I figured I should contribute them.
andrewkroh
force-pushed
the
feature/ab/docs-comments-nits
branch
from
October 24, 2023 13:52
8cd0f09
to
aa7dba5
Compare
Collaborator
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
reviewed
Oct 24, 2023
It looks like this was supposed to be a bitwise clear operation to remove ConfigChange and AttributesModified before the lookup from actionOrderMap. Co-authored-by: Dan Kortschak <[email protected]>
efd6
approved these changes
Oct 26, 2023
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
Really minor fixes to docs and comments in auditbeat/modules. As I was reading the code I was applying some changes, so I figured I should contribute them. Removing an unnecessary cast revealed an incorrect operation between `& ^` vs `&^`. It looks like this was supposed to be a bitwise clear `&^` operation to remove ConfigChange and AttributesModified before the lookup from actionOrderMap. --------- Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Really minor fixes to docs and comments in auditbeat/modules. As I was reading the code I was applying some changes, so I figured I should contribute them.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.