Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditbeat/module - docs and comment nits #36952

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Oct 24, 2023

Proposed commit message

Really minor fixes to docs and comments in auditbeat/modules. As I was reading the code I was applying some changes, so I figured I should contribute them.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 24, 2023
@andrewkroh andrewkroh added the backport-skip Skip notification from the automated backport with mergify label Oct 24, 2023
@elastic elastic deleted a comment from mergify bot Oct 24, 2023
Really minor fixes to docs and comments in auditbeat/modules.
As I was reading the code I was applying some changes, so I figured
I should contribute them.
@andrewkroh andrewkroh force-pushed the feature/ab/docs-comments-nits branch from 8cd0f09 to aa7dba5 Compare October 24, 2023 13:52
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 43 min 30 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh marked this pull request as ready for review October 24, 2023 14:39
@andrewkroh andrewkroh requested a review from a team as a code owner October 24, 2023 14:39
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

auditbeat/module/file_integrity/action.go Outdated Show resolved Hide resolved
auditbeat/module/auditd/audit_linux.go Outdated Show resolved Hide resolved
andrewkroh and others added 2 commits October 26, 2023 15:23
It looks like this was supposed to be a bitwise clear operation to remove ConfigChange and AttributesModified before the lookup from actionOrderMap.

Co-authored-by: Dan Kortschak <[email protected]>
@andrewkroh andrewkroh requested a review from efd6 October 26, 2023 21:36
@andrewkroh andrewkroh enabled auto-merge (squash) October 26, 2023 21:41
@andrewkroh andrewkroh merged commit b0455f4 into elastic:main Oct 26, 2023
5 of 8 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Really minor fixes to docs and comments in auditbeat/modules.
As I was reading the code I was applying some changes, so I figured
I should contribute them.

Removing an unnecessary cast revealed an incorrect operation between
`& ^` vs `&^`.  It looks like this was supposed to be a bitwise clear `&^` 
operation to remove ConfigChange and AttributesModified before the 
lookup from actionOrderMap.

---------

Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants