Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Retry on no previous state #36842

Merged
merged 4 commits into from
Oct 13, 2023
Merged

[Heartbeat] Retry on no previous state #36842

merged 4 commits into from
Oct 13, 2023

Conversation

emilioalvap
Copy link
Collaborator

Proposed commit message

Add "no previous state found" condition to state transition to trigger retries. With this change, hearbeat will attempt a retry (if configured to do so) not only when the previous state is "up" but also when it wasn't possible to find a previous state.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Build heartbeat locally.
  2. Configure a monitor with a non-previously existing ID and maxAttempts > 1,point it somewhere to get a "down" result.
  3. Run HB and check a retry is triggered on the first down result.

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0 labels Oct 13, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner October 13, 2023 15:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@emilioalvap emilioalvap added the backport-v8.11.0 Automated backport with mergify label Oct 13, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 52 min 57 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@vigneshshanmugam vigneshshanmugam enabled auto-merge (squash) October 13, 2023 18:12
@vigneshshanmugam vigneshshanmugam merged commit df4d550 into elastic:main Oct 13, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
@emilioalvap @mergify
[Heartbeat] Retry on no previous state (#36842)
c36c499 
* Add empty state to retry cond

* Remove unwanted test

* Add changelog

* address review

---------

Co-authored-by: vigneshshanmugam <[email protected]>
(cherry picked from commit df4d550)
@mergify mergify bot mentioned this pull request Oct 13, 2023
Merged
vigneshshanmugam pushed a commit that referenced this pull request Oct 13, 2023
@mergify @emilioalvap
[Heartbeat] Retry on no previous state (#36842) (#36845)
f17aa54 
* Add empty state to retry cond

* Remove unwanted test

* Add changelog

* address review

---------

Co-authored-by: vigneshshanmugam <[email protected]>
(cherry picked from commit df4d550)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@emilioalvap @vigneshshanmugam @Scholar-Li
[Heartbeat] Retry on no previous state (elastic#36842)
e29ab9c 
* Add empty state to retry cond

* Remove unwanted test

* Add changelog

* address review

---------

Co-authored-by: vigneshshanmugam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.11.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilioalvap @elasticmachine @vigneshshanmugam