Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/docs/inputs/input-cel: fix docs for redact #36754

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 5, 2023

Proposed commit message

The documentation shows the type of redact.fields as a scalar. This is not correct; it should be an array.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

The documentation incorrectly shows the type of redact as a scalar. This
is not correct; it should be an array.
@efd6 efd6 added bug docs Filebeat Filebeat 8.12-candidate backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 5, 2023
@efd6 efd6 self-assigned this Oct 5, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 5, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 5, 2023
@efd6 efd6 marked this pull request as ready for review October 5, 2023 03:34
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 9 min 30 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 2988148 into elastic:main Oct 5, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
The documentation shows the type of redact.fields as a scalar. This is not
correct; it should be an array.

(cherry picked from commit 2988148)
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
The documentation shows the type of redact.fields as a scalar. This is not
correct; it should be an array.

(cherry picked from commit 2988148)
efd6 added a commit that referenced this pull request Oct 5, 2023
…36755)

The documentation shows the type of redact.fields as a scalar. This is not
correct; it should be an array.

(cherry picked from commit 2988148)

Co-authored-by: Dan Kortschak <[email protected]>
efd6 added a commit that referenced this pull request Oct 5, 2023
…36756)

The documentation shows the type of redact.fields as a scalar. This is not
correct; it should be an array.

(cherry picked from commit 2988148)

Co-authored-by: Dan Kortschak <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
…6754)

The documentation shows the type of redact.fields as a scalar. This is not
correct; it should be an array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.12-candidate backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify bug docs Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants