Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve explanation of dsl names in config docs #36750

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

fearful-symmetry
Copy link
Contributor

Proposed commit message

closes #36733

This expands the config documentation for DSL, elaborating on the template variables used by the data_stream_pattern config value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added Team:Elastic-Agent Label for the Agent team backport-v8.11.0 Automated backport with mergify labels Oct 4, 2023
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner October 4, 2023 17:59
@fearful-symmetry fearful-symmetry self-assigned this Oct 4, 2023
@fearful-symmetry fearful-symmetry requested review from a team as code owners October 4, 2023 17:59
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 4, 2023
@fearful-symmetry
Copy link
Contributor Author

heartbeat CI error seems unrelated...

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T20:08:38.743+0000

  • Duration: 99 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 28478
Skipped 2013
Total 30491

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HB changes LGTM

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fearful-symmetry fearful-symmetry merged commit 7bbafa2 into elastic:main Oct 5, 2023
21 checks passed
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 7bbafa2)
@fearful-symmetry fearful-symmetry added backport-v8.11.0 Automated backport with mergify and removed backport-v8.11.0 Automated backport with mergify labels Oct 5, 2023
@fearful-symmetry
Copy link
Contributor Author

@Mergifyio backport 8.11

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2023

backport 8.11

✅ Backports have been created

fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Oct 5, 2023
fearful-symmetry added a commit that referenced this pull request Oct 6, 2023
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve DSL reference documentation to work by default
6 participants