Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][gcp-pubsub] - Set EventNormalization as false #36716

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Oct 2, 2023

Proposed commit message

EventNormalization is ON by default which iterates over all the fields for each event and if any nested fields are observed, it removes null values and drops unsupported datatypes.
However, just like AWS S3 Input, GCP PubSub input only produces events with basic types, hence EventNormalization is not required. This reduces the processing by 2 hops as seen from CPU Profile.

Performance Tests:
1.

subscription.num_goroutines: 1
subscription.max_outstanding_messages: 1000

With Event Normalization ~ 700 messages / sec
Without Event Normalization ~ 670 messages / sec

subscription.num_goroutines: 2
subscription.max_outstanding_messages: 2000

With Event Normalization ~ 1560 messages / sec
Without Event Normalization ~ 1600 messages / sec

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kcreddy? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned kcreddy Oct 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp-pubsub-perf-imprv upstream/gcp-pubsub-perf-imprv
git merge upstream/main
git push upstream gcp-pubsub-perf-imprv

@kcreddy kcreddy changed the title update EventNormalization as false [filebeat][gcs] - Set EventNormalization as false Oct 2, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-02T11:30:16.976+0000

  • Duration: 75 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 3193
Skipped 174
Total 3367

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kcreddy kcreddy marked this pull request as ready for review October 2, 2023 11:53
@kcreddy kcreddy requested a review from a team as a code owner October 2, 2023 11:53
@kcreddy kcreddy changed the title [filebeat][gcs] - Set EventNormalization as false [filebeat][gcp-pubsub] - Set EventNormalization as false Oct 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy added Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify labels Oct 2, 2023
@kcreddy kcreddy merged commit 4c5f245 into elastic:main Oct 2, 2023
8 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
* Update EventNormalization as false for GCP Pubsub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants