Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/cel: add support for partial evaluation debug logging #36652

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 22, 2023

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Run go test -v -run TestInput/debug in the cel package. You should see the logs for the test, including a line like so

{"log.level":"debug", ... ,"log.logger":"cel_test.cel_debug"," ... ,"message":"DEBUG", ... ,"tag":"partial sum","value":5, ...}

for the happy path test and like so

{"log.level":"debug", ... ,"log.logger":"cel_test.cel_debug", ... ,"message":"ERROR", ... ,"tag":"divide by zero","error":{"message":"division by zero"}, ...}

for the error path test.

The surprising field rename from "value" to "error" that is not explainable from the code in this change is undocumented pixie dust from zap. I guess it's OK.

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Sep 22, 2023
@efd6 efd6 self-assigned this Sep 22, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 22, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-28T22:10:02.296+0000

  • Duration: 25 min 5 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review September 22, 2023 20:59
@efd6 efd6 requested a review from a team as a code owner September 22, 2023 20:59
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cel_debug upstream/cel_debug
git merge upstream/main
git push upstream cel_debug

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
I guess there is no easy way to create unit test if log is being produced with the specified tag ?

@efd6
Copy link
Contributor Author

efd6 commented Sep 28, 2023

The logging behaviour is hard to test here, but is tested in the library. elastic/mito#40 (testdata/debug.txt)

@efd6
Copy link
Contributor Author

efd6 commented Sep 28, 2023

/test

1 similar comment
@efd6
Copy link
Contributor Author

efd6 commented Sep 28, 2023

/test

@efd6 efd6 merged commit 6813a21 into elastic:main Sep 28, 2023
6 of 8 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants