-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/cel: add support for partial evaluation debug logging #36652
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
I guess there is no easy way to create unit test if log is being produced with the specified tag
?
The logging behaviour is hard to test here, but is tested in the library. elastic/mito#40 (testdata/debug.txt) |
/test |
1 similar comment
/test |
Proposed commit message
See title.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Run
go test -v -run TestInput/debug
in the cel package. You should see the logs for the test, including a line like sofor the happy path test and like so
for the error path test.
The surprising field rename from "value" to "error" that is not explainable from the code in this change is undocumented pixie dust from zap. I guess it's OK.
Related issues
Use cases
Screenshots
Logs