Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Beta banner from filebeat ratelimit function #36562

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

nimarezainia
Copy link
Contributor

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@nimarezainia nimarezainia requested a review from a team as a code owner September 12, 2023 06:57
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2023
@nimarezainia nimarezainia requested a review from a team September 12, 2023 06:58
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @nimarezainia? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@nimarezainia nimarezainia requested review from kilfoyle and removed request for ycombinator and leehinman September 12, 2023 06:58
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-12T06:58:03.700+0000

  • Duration: 9 min 33 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 12, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2023
@kilfoyle kilfoyle added the backport-v8.10.0 Automated backport with mergify label Sep 12, 2023
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've added a backport-v8.10.0 label so that this change will go into the current docs.

Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimarezainia nimarezainia merged commit 58db08f into main Sep 26, 2023
8 checks passed
@nimarezainia nimarezainia deleted the nimarezainia-patch-3 branch September 26, 2023 23:26
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
(cherry picked from commit 58db08f)
rdner pushed a commit that referenced this pull request Sep 29, 2023
(cherry picked from commit 58db08f)

Co-authored-by: nima <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.10.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants