Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh autocompletion failing tests #36551

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Sep 11, 2023

Proposed commit message

It looks like the output of the autocompletion script for zsh has
changed, hence the tests are failing. This commit fixes it.

The autocompletion is generated by an external
package (github.com/spf13/cobra), so this commit just updates the test
with the current output.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Author's Checklist
## How to test this PR locally

Related issues

## Use cases
## Screenshots
## Logs

It looks like the output of the autocompletion script for zsh has
changed, hence the tests are failing. This commit fixes it.

The autocompletion is generated by an external
package (github.com/spf13/cobra), so this commit just updates the test
with the current output.
@belimawr belimawr requested a review from a team as a code owner September 11, 2023 10:49
@belimawr belimawr requested review from ycombinator and rdner and removed request for a team September 11, 2023 10:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 11, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-11T10:49:59.499+0000

  • Duration: 79 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 27511
Skipped 2024
Total 29535

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 11, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 11, 2023
@pierrehilbert pierrehilbert linked an issue Sep 11, 2023 that may be closed by this pull request
@belimawr belimawr merged commit 12e703b into elastic:8.9 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
3 participants