Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10](backport #36484) libbeat/processors/add_process_metadata: Add default cgroup.regex for add_process_metadata #36540

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 8, 2023

This is an automatic backport of pull request #36484 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

… add_process_metadata (#36484)

Replace the existing cgroup_prefixes default with a default cgroup_regex. The new default will match the same cgroup paths as the old cgroup_prefixes value plus more. Out of the box it will match cgroup paths from modern Kubernetes and Podman versions. Existing users of cgroup_prefixes and cgroup_regex should see no breaking change.

This removes the undocumented behavior that when cgroup_prefixes was used that it would return a value that matched [\w]{64} for cgroup v2 paths. This was inconsistent because it arbitrary applied only to cgroup v2 paths and it could be prone to false matches.

(cherry picked from commit 80ed33b)
@mergify mergify bot requested a review from a team as a code owner September 8, 2023 13:56
@mergify mergify bot added the backport label Sep 8, 2023
@mergify mergify bot requested review from belimawr and fearful-symmetry and removed request for a team September 8, 2023 13:56
@mergify mergify bot assigned bhapas Sep 8, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-08T13:56:47.489+0000

  • Duration: 81 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 28138
Skipped 2015
Total 30153

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor Author

mergify bot commented Sep 11, 2023

This pull request has not been merged yet. Could you please review and merge it @bhapas? 🙏

@bhapas bhapas merged commit 0fe18e2 into 8.10 Sep 11, 2023
8 checks passed
@bhapas bhapas deleted the mergify/bp/8.10/pr-36484 branch September 11, 2023 04:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants