-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] httplog - reduce duplication to shrink log message size #36531
[Filebeat] httplog - reduce duplication to shrink log message size #36531
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
The request and response bodies are included twice in request tracer messages. The body appears in both the event.original and http.{request,response}.body.content. This removes the body from the event.original. It should help reduce the log message sizes for large responses.
bed727b
to
c2ea764
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
The request and response bodies are included twice in request tracer messages. The body appears in both the event.original and http.{request,response}.body.content. This removes the body from the event.original. It should help reduce the log message sizes for large responses.
Proposed commit message
The request and response bodies are included twice in request tracer messages. The body appears in both the event.original and http.{request,response}.body.content. This removes the body from the event.original. It should help reduce the log message sizes for large responses.
The motivation is to allow larger responses to fit into the request tracer log. When a log message exceeds the max size of a log (default 1 MiB) then the message is dropped and a warning is logged by zap to stderr.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.