-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/httpjson: re-enable previously flakey first_event test #36525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
Filebeat
Team:Security-External Integrations
backport-skip
Skip notification from the automated backport with mergify
8.11-candidate
labels
Sep 6, 2023
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Sep 6, 2023
…nt test With the change from concurrent to sequential processing this test is no longer flakey. This is confirmed by re-applying a delay to the publication of the first event in a set of events. This change causes the concurrent code to fail consistently, but the current sequential code passes. The test change used to test the flake is diff --git a/x-pack/filebeat/input/httpjson/request.go b/x-pack/filebeat/input/httpjson/request.go index 6a1d926ab4..3ed904f16d 100644 --- a/x-pack/filebeat/input/httpjson/request.go +++ b/x-pack/filebeat/input/httpjson/request.go @@ -16,6 +16,7 @@ import ( "reflect" "strconv" "strings" + "time" "github.com/PaesslerAG/jsonpath" @@ -741,6 +742,10 @@ func newPublisher(trCtx *transformContext, pub inputcursor.Publisher, publish bo } func (p *publisher) event(_ context.Context, msg mapstr.M) { + if p.n == 0 { + time.Sleep(10 * time.Millisecond) + } + if p.pub != nil { event, err := makeEvent(msg) if err != nil {
efd6
force-pushed
the
35432-httpjson-unskip
branch
from
September 6, 2023 21:13
1a1d492
to
9b42b47
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍾
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…nt test (elastic#36525) With the change from concurrent to sequential processing this test is no longer flakey. This is confirmed by re-applying a delay to the publication of the first event in a set of events. This change causes the concurrent code to fail consistently, but the current sequential code passes. The test change used to test the flake is diff --git a/x-pack/filebeat/input/httpjson/request.go b/x-pack/filebeat/input/httpjson/request.go index 6a1d926ab4..3ed904f16d 100644 --- a/x-pack/filebeat/input/httpjson/request.go +++ b/x-pack/filebeat/input/httpjson/request.go @@ -16,6 +16,7 @@ import ( "reflect" "strconv" "strings" + "time" "github.com/PaesslerAG/jsonpath" @@ -741,6 +742,10 @@ func newPublisher(trCtx *transformContext, pub inputcursor.Publisher, publish bo } func (p *publisher) event(_ context.Context, msg mapstr.M) { + if p.n == 0 { + time.Sleep(10 * time.Millisecond) + } + if p.pub != nil { event, err := makeEvent(msg) if err != nil {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.11-candidate
backport-skip
Skip notification from the automated backport with mergify
enhancement
Filebeat
Filebeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
With the change from concurrent to sequential processing this test is no longer flakey. This is confirmed by re-applying a delay to the publication of the first event in a set of events. This change causes the concurrent code to fail consistently, but the current sequential code passes.
The test change used to test the flake is
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs