Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/libbeat/common/aws: add support for external IDs #36322

Merged
merged 1 commit into from
Sep 6, 2023
Merged

x-pack/libbeat/common/aws: add support for external IDs #36322

merged 1 commit into from
Sep 6, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 15, 2023

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Aug 15, 2023
@efd6 efd6 self-assigned this Aug 15, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 15, 2023
@efd6 efd6 requested a review from andrewkroh August 15, 2023 06:50
@efd6 efd6 force-pushed the 36321-aws branch 2 times, most recently from 722d2a1 to ea7f3de Compare August 15, 2023 07:12
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 15, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-05T21:27:45.666+0000

  • Duration: 143 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 16514
Skipped 1137
Total 17651

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor Author

efd6 commented Aug 15, 2023

/test

3 similar comments
@efd6
Copy link
Contributor Author

efd6 commented Aug 15, 2023

/test

@efd6
Copy link
Contributor Author

efd6 commented Aug 15, 2023

/test

@efd6
Copy link
Contributor Author

efd6 commented Aug 16, 2023

/test

@efd6 efd6 force-pushed the 36321-aws branch 3 times, most recently from 4634a63 to d85238f Compare August 22, 2023 22:41
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 36321-aws branch 3 times, most recently from e46c60b to 52698e2 Compare August 26, 2023 08:38
@efd6
Copy link
Contributor Author

efd6 commented Aug 26, 2023

/test

@efd6 efd6 mentioned this pull request Aug 27, 2023
Open
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 marked this pull request as ready for review September 6, 2023 01:06
@efd6 efd6 requested review from a team as code owners September 6, 2023 01:06
@efd6 efd6 requested review from belimawr and rdner September 6, 2023 01:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 6, 2023
@efd6 efd6 enabled auto-merge (squash) September 6, 2023 08:40
zmoog
zmoog approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@efd6 efd6 merged commit 4cf4292 into elastic:main Sep 6, 2023
10 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/libbeat/common/aws: add support for external IDs (elastic#36322)
eb245ad
@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@belimawr belimawr belimawr approved these changes

@zmoog zmoog zmoog approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Config - Allow specifying an external_id for assume role
6 participants
@efd6 @elasticmachine @zmoog @belimawr @andrewkroh @pierrehilbert