-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat][httpjson] - Added support for Okta Oauth2 provider #36273
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM.
But it would be nice if someone with better knowledge of httpjson to have a review the change and module upgrades as well.
@andrewkroh will require an approval from your end as a beats tech lead review is mandatory here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any tests except for the configuration. What manual testing has been performed? Ideally there would be some test to exercise the TokenSource implementation.
@andrewkroh Have tested it extensively with an okta dev account and used a httpjson config similar to the okta integration to poll system logs and everything thing is working as expected. |
Could you please add those setup steps to the PR description in case someone else needs to replicate this testing in the future. |
@andrewkroh I have resolved all the PR suggestions and updated the PR description with steps to test this feature locally. |
…c#36273) * initial commit for okta oauth provider support in httpjson * removed unused vars * updated notice * updated changelog * resolved PR comments * improved docs, updated with PR suggestions
Type of change
Proposed commit message
Added support for Okta as a separate OAuth2 provider. This was required because specific use cases
require access tokens with okta.* scopes, which involves a specific 2 step auth mechanism using a private
RSA JWK to generate a JWT which is in turn used to fetch an access token. Standard client_id & client_secrets don't
work in this scenario.
Checklist
- [] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Other details could also be read according to your requirements, the scope and endpoint url need to be changed accordingly.
Sample configuration for reading system logs via Okta System Log API:
Related issues
Use cases
Screenshots
Logs