Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md - Update checklist #36167

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

pierrehilbert
Copy link
Collaborator

@pierrehilbert pierrehilbert commented Jul 28, 2023

What does this PR do?

Add a new item in the checklist about commit title and message that should be explanatory.

Why is it important?

Ensure that we pay attention to our commit message and title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Add a new item in the checklist about commit title and message that should be explanatory.
@pierrehilbert pierrehilbert added docs Team:Elastic-Agent Label for the Agent team labels Jul 28, 2023
@pierrehilbert pierrehilbert requested a review from a team as a code owner July 28, 2023 07:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pierrehilbert? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert requested a review from jlind23 July 28, 2023 07:21
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-28T07:16:04.809+0000

  • Duration: 8 min 51 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert merged commit 3ea0c53 into main Jul 28, 2023
@pierrehilbert pierrehilbert deleted the pierrehilbert-patch-3 branch July 28, 2023 10:11
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Add a new item in the checklist about commit title and message that should be explanatory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants