-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump PyYAML's version from 5.3.1 to avoid security risks #36119
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
5268a06
to
31550a5
Compare
Okay this is not going to be easy to fix because:
For docker-compose, the latest Py release was 1.29.2 and after that they deprecated it. So, we have to use PyYAML<6 |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
I am not quite sure how both work as bumping to 5.3.1 and setting in the next file >=6.0.0 seems conflicting to me. I am approving because changes only involve the versions |
No @gizas. It is not working. I've mentioned the issue I'm currently facing in the PR description. docker-compose requires Moving this PR to draft as the fix is not ready. We have to see how to fix it. Please take a look at the linked issues in the PR description as well. Suggestions are welcomed. One ugly fix I saw in PyYAML's discussion is this: yaml/pyyaml#702 (comment) |
What does this PR do?
CPython 3.0 was released recently which has introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available. See: yaml/pyyaml#601
#36091 pinned the version of PyYAML to 5.3.1 but I found from a recent discussion yaml/pyyaml#601 (comment) that there's a CVE associated with the same: CVE-2020-14343.
Also, see: aws/aws-cli#8036 (comment) and aws/aws-cli#8036 (comment)
Why is it important?
Fixes CI issues temporarily and also makes us safe from CVE-2020-14343.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
5.4
: Pin Cython build constraint to < 3.0 yaml/pyyaml#7265.4
: Pin Cython build constraint to < 3.0 yaml/pyyaml#726 (comment) (Exactly our issue)