Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the wrong event type for a new file #36098

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix the wrong event type for a new file #36098

merged 1 commit into from
Jul 18, 2023

Conversation

rdner
Copy link
Member

@rdner rdner commented Jul 18, 2023

What does this PR do?

It's supposed to emit a create event, not a write event when a previously ignored empty file gets written to.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@rdner
Fix the wrong event type for a new file
a38e12d 
It's supposed to emit a `create` event, not a `write` event when a
previously ignored empty file gets written to.
@rdner rdner added Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-7.17 Automated backport to the 7.17 branch with mergify bugfix labels Jul 18, 2023
@rdner rdner requested a review from a team as a code owner July 18, 2023 09:01
@rdner rdner self-assigned this Jul 18, 2023
@rdner rdner requested review from ycombinator and leehinman July 18, 2023 09:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 18, 2023
@rdner rdner enabled auto-merge (squash) July 18, 2023 09:11
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T09:02:04.788+0000

  • Duration: 74 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 8062
Skipped 757
Total 8819

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert requested a review from faec July 18, 2023 12:08
leehinman
leehinman approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for adding that test, this should help us maintain the behavior.

@rdner rdner merged commit f52d38a into elastic:main Jul 18, 2023
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
@rdner @mergify
Fix the wrong event type for a new file (#36098)
6cb51d1 
It's supposed to emit a `create` event, not a `write` event when a
previously ignored empty file gets written to.

(cherry picked from commit f52d38a)
@mergify mergify bot mentioned this pull request Jul 18, 2023
Merged
@rdner rdner deleted the another-empty-file-fix branch July 18, 2023 14:51
rdner added a commit that referenced this pull request Jul 18, 2023
@mergify @rdner
Fix the wrong event type for a new file (#36098) (#36102)
ec49a82 
It's supposed to emit a `create` event, not a `write` event when a
previously ignored empty file gets written to.

(cherry picked from commit f52d38a)

Co-authored-by: Denis <[email protected]>
@rdner rdner mentioned this pull request Jul 18, 2023
Closed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@rdner @Scholar-Li
Fix the wrong event type for a new file (elastic#36098)
081dcee 
It's supposed to emit a `create` event, not a `write` event when a
previously ignored empty file gets written to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec

Assignees

@rdner rdner

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify bugfix Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdner @elasticmachine @leehinman