Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prealloc linter rule #35921

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Adding prealloc linter rule #35921

merged 3 commits into from
Jun 28, 2023

Conversation

amitkanfer
Copy link
Collaborator

Adding the prealloc linter rule:
https://github.com/alexkohler/prealloc

This will help us identify possible performance optimizations

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 27, 2023
@botelastic
Copy link

botelastic bot commented Jun 27, 2023

This pull request doesn't have a Team:<team> label.

@amitkanfer amitkanfer marked this pull request as ready for review June 27, 2023 12:56
@amitkanfer amitkanfer requested a review from a team as a code owner June 27, 2023 12:56
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @amitkanfer? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

.golangci.yml Outdated Show resolved Hide resolved
Co-authored-by: Craig MacKenzie <[email protected]>
@amitkanfer amitkanfer requested a review from cmacknz June 27, 2023 13:03
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-27T18:08:28.558+0000

  • Duration: 12 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@amitkanfer amitkanfer merged commit 2a5bfb1 into main Jun 28, 2023
@amitkanfer amitkanfer deleted the add_prealloc_linter branch June 28, 2023 07:17
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants