-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose filestream metrics together with log input #35835
Expose filestream metrics together with log input #35835
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
The filestream input now also exposes the following metrics: - filebeat.harvester.closed - filebeat.harvester.open_file - filebeat.harvester.started - filebeat.harvester.running
2a92e6f
to
1c5582b
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
@belimawr seems like some metric tests are failing now, can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change looks ok,
tested also with closing files, works
I removed the flaky test and will implement it on #35863. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was approved by @michalpristas before your remove the flaky test
… with log input metrics #35835 (#36023) * Tests for exposing filestream metrics together with log input metrics #35835 (#35886) This commit implements integration tests for filestream metrics. It also moves the "integration test framework" from `x-pack/filebeat` to `libbeat` and implements some improvements on it. (cherry picked from commit e16de71) * Remove test for feature that was not backported. --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]>
What does this PR do?
The filestream input now also exposes the following metrics:
Why is it important?
The filestream input did not expose those metrics, which is very confusing, especially for users migrating from the log input
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Author's ChecklistHow to test this PR locally
/tmp/filestream*.log
.curl -sL http://localhost:5066/stats | jq '.[].harvester | select(.!=null)'
Related issues
## Use cases## Screenshots## Logs