-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make filestream tests more reliable and provide debug logs #35754
make filestream tests more reliable and provide debug logs #35754
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This commit brings the improvements from elastic#35754 to this PR.
This commit brings the improvements from elastic#35754 to this PR.
From my understanding, this one should be close in favor of #35759. |
fswatcher now uses the modification time and changes in the file size to trigger either a truncate or write event. Other small changes: - Fixed some log formatting issue and only log the error if it is not `context.Canceled` - Fixes and improves some log messages. - Brings the improvements from #35754 to this PR.
This pull request is now in conflicts. Could you fix it? 🙏
|
#35759 is merged and adopted the improvements suggested here. |
fswatcher now uses the modification time and changes in the file size to trigger either a truncate or write event. Other small changes: - Fixed some log formatting issue and only log the error if it is not `context.Canceled` - Fixes and improves some log messages. - Brings the improvements from #35754 to this PR. (cherry picked from commit bdb67bc) # Conflicts: # filebeat/input/filestream/filestream.go # filebeat/input/filestream/internal/input-logfile/clean.go
fswatcher now uses the modification time and changes in the file size to trigger either a truncate or write event. Other small changes: - Fixed some log formatting issue and only log the error if it is not `context.Canceled` - Fixes and improves some log messages. - Brings the improvements from #35754 to this PR. (cherry picked from commit bdb67bc) # Conflicts: # filebeat/input/filestream/filestream.go # filebeat/input/filestream/internal/input-logfile/clean.go --------- Co-authored-by: Tiago Queiroz <[email protected]>
What does this PR do?
waitUntilOffsetInRegistry
Why is it important?
The TestFilestreamTruncateBlockedOutput would fail regularly in CI. These changes stop the failures locally, but even if the failures occur in CI, we will now have more debug data to try and address what is failing.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues