Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Beats tech leads the owners of go.mod. #35684

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 5, 2023

We have found the Elastic Agent team is being required to review PRs exclusively because we are the maintainers of go.mod and related files. To avoid making us the bottleneck for these changes, we've created the Beats Tech Leads team so that we can share ownership of these files and unblock our own teams faster.

The alternative is to mark these files as unowned, but since go.mod updates can be critical to product security I don't want to leave these files ownerless. I will also make this group the owner of the CODEOWNER file itself.

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 5, 2023
@cmacknz cmacknz self-assigned this Jun 5, 2023
@cmacknz cmacknz requested a review from a team as a code owner June 5, 2023 15:24
@cmacknz cmacknz requested review from ycombinator and belimawr June 5, 2023 15:24
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @cmacknz? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@cmacknz cmacknz added the backport-v8.8.0 Automated backport with mergify label Jun 5, 2023
@cmacknz cmacknz requested a review from rdner June 5, 2023 15:26
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-05T15:24:55.274+0000

  • Duration: 14 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz merged commit 01aa790 into elastic:main Jun 5, 2023
@cmacknz cmacknz deleted the change-go-mod-ownership branch June 5, 2023 16:19
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
cmacknz added a commit that referenced this pull request Jun 5, 2023
(cherry picked from commit 01aa790)

Co-authored-by: Craig MacKenzie <[email protected]>
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.8.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants