-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Beats tech leads the owners of go.mod. #35684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
added
the
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
label
Jun 5, 2023
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jun 5, 2023
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
pierrehilbert
approved these changes
Jun 5, 2023
andrewkroh
approved these changes
Jun 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
(cherry picked from commit 01aa790)
cmacknz
added a commit
that referenced
this pull request
Jun 5, 2023
(cherry picked from commit 01aa790) Co-authored-by: Craig MacKenzie <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.8.0
Automated backport with mergify
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found the Elastic Agent team is being required to review PRs exclusively because we are the maintainers of go.mod and related files. To avoid making us the bottleneck for these changes, we've created the Beats Tech Leads team so that we can share ownership of these files and unblock our own teams faster.
The alternative is to mark these files as unowned, but since go.mod updates can be critical to product security I don't want to leave these files ownerless. I will also make this group the owner of the CODEOWNER file itself.