-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRC validation to Zoom module #35604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemamartinez
added
enhancement
Filebeat
Filebeat
Team:Security-External Integrations
backport-skip
Skip notification from the automated backport with mergify
labels
May 29, 2023
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
May 29, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
May 29, 2023
We are doing some minor work on the input first before merging this one, as we are adding a separate secret option. |
Collaborator
chemamartinez
force-pushed
the
zoom-crc-support
branch
from
May 31, 2023 15:48
5c9f59e
to
c31b765
Compare
chemamartinez
changed the title
Add CRC provider option to Zoom module
Add CRC validation to Zoom module
May 31, 2023
chemamartinez
force-pushed
the
zoom-crc-support
branch
from
May 31, 2023 16:18
c31b765
to
3369b5f
Compare
chemamartinez
force-pushed
the
zoom-crc-support
branch
from
May 31, 2023 16:53
3369b5f
to
08a8c11
Compare
4 tasks
6 tasks
chemamartinez
force-pushed
the
zoom-crc-support
branch
from
June 1, 2023 12:16
60acf3b
to
6d33699
Compare
leehinman
approved these changes
Jun 1, 2023
P1llus
approved these changes
Jun 1, 2023
efd6
reviewed
Jun 1, 2023
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-skip
Skip notification from the automated backport with mergify
enhancement
Filebeat
Filebeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request adds:
secret.value
as a salt for the CRC procedure. Instead, a new option calledcrc.secret
is added so for each module it can be filled with the proper value.crc.enabled
: enable the CRC validationcrc.secret
: the secret token that is used for the CRC validationMore information about this validation is available here.
Changes in the input related to this CRC validation can be found at #35204.
Checklist
Related issues