Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRC validation to Zoom module #35604

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented May 29, 2023

What does this PR do?

This pull request adds:

  • Update the HTTP endpoint input to avoid using the secret.value as a salt for the CRC procedure. Instead, a new option called crc.secret is added so for each module it can be filled with the proper value.
  • Added new options to the Zoom module:
    • crc.enabled: enable the CRC validation
    • crc.secret: the secret token that is used for the CRC validation

More information about this validation is available here.

Changes in the input related to this CRC validation can be found at #35204.

Checklist

  • My code follows the style guidelines of this project

Related issues

@chemamartinez chemamartinez added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify labels May 29, 2023
@chemamartinez chemamartinez requested a review from a team as a code owner May 29, 2023 10:34
@chemamartinez chemamartinez self-assigned this May 29, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 29, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 29, 2023
@P1llus
Copy link
Member

P1llus commented May 29, 2023

We are doing some minor work on the input first before merging this one, as we are adding a separate secret option.

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T12:18:36.048+0000

  • Duration: 74 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 7834
Skipped 749
Total 8583

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@chemamartinez chemamartinez requested a review from a team as a code owner May 31, 2023 15:48
@chemamartinez chemamartinez changed the title Add CRC provider option to Zoom module Add CRC validation to Zoom module May 31, 2023
@chemamartinez chemamartinez marked this pull request as draft May 31, 2023 15:59
@chemamartinez chemamartinez merged commit 7eb4a22 into elastic:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants