Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync filebeat system auth dataset with system integration #35581

Merged
merged 1 commit into from
May 26, 2023
Merged

sync filebeat system auth dataset with system integration #35581

merged 1 commit into from
May 26, 2023

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Syncs the Filebeat system/auth dataset with version 1.29.0 of the system integration.

Why is it important?

  • consistent parsing of auth events between Filebeat and Agent
  • fixes bug where hostnames were incorrectly being copied to source.ip, which caused indexing errors because the hostname didn't satisfy the type requirements of ip.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd filebeat
TESTING_FILEBEAT_MODULES=system TESTING_FILEBEAT_FILESETS=auth mage -v pythonIntegTest

Related issues

@leehinman leehinman added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels May 25, 2023
@leehinman leehinman requested a review from a team as a code owner May 25, 2023 20:11
@leehinman leehinman requested review from rdner and cmacknz May 25, 2023 20:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 25, 2023
@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 25, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-26T02:28:43.960+0000

  • Duration: 72 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 7815
Skipped 749
Total 8564

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leehinman leehinman added the backport-v8.8.0 Automated backport with mergify label May 26, 2023
@leehinman
sync filebeat system auth dataset with system integration
5d8e233 
- sync with version 1.29.0 of system integration
@leehinman leehinman force-pushed the pam_sshd_logs_fix branch from eeb2c4b to 5d8e233 Compare May 26, 2023 02:28
@leehinman leehinman merged commit e870503 into elastic:main May 26, 2023
mergify bot pushed a commit that referenced this pull request May 26, 2023
@leehinman @mergify
sync filebeat system auth dataset with system integration (#35581)
73620ec 
- sync with version 1.29.0 of system integration

(cherry picked from commit e870503)
@mergify mergify bot mentioned this pull request May 26, 2023
Merged
leehinman added a commit that referenced this pull request May 30, 2023
@mergify @leehinman
[8.8](backport #35581) sync filebeat system auth dataset with system …
1c4c61f 
…integration (#35597)

* sync filebeat system auth dataset with system integration (#35581)

- sync with version 1.29.0 of system integration

(cherry picked from commit e870503)

* fix changelog merge

---------

Co-authored-by: Lee E Hinman <[email protected]>
Co-authored-by: Lee E. Hinman <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@leehinman @chrisberkhout
sync filebeat system auth dataset with system integration (#35581)
5302b2e 
- sync with version 1.29.0 of system integration
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
Closed
6 tasks
@leehinman leehinman deleted the pam_sshd_logs_fix branch September 11, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@leehinman leehinman

Labels
backport-v8.8.0 Automated backport with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leehinman @elasticmachine @cmacknz