Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNER update for obs-infraobs-integrations. #35545

Conversation

lalit-satapathy
Copy link
Contributor

@lalit-satapathy lalit-satapathy commented May 23, 2023

As part of the Beats repository quality gates effort, need to keep the CODEOWNERS for the beats repo up-to-date.

Updating the beats modules/inputs which were owned by @elastic/obs-infraobs-integrations

  • Left the entries which are either ambiguous (example: module/icinga) not owned(example: module/kibana).

  • Added modules not listed earlier (example: many in /metricbeat/module/*)
  • Trying to keep it consistent with CODEOWNERS in the integration repo.

There will be still modules left in @elastic/integrations which needs to be cleaned-up.

Please review and let's know, if anything wrongly mapped.

@lalit-satapathy lalit-satapathy self-assigned this May 23, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 23, 2023
@lalit-satapathy lalit-satapathy added the Team:Integrations Label for the Integrations team label May 23, 2023
@mergify
Copy link
Contributor

mergify bot commented May 23, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @lalit-satapathy? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 23, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T05:13:55.420+0000

  • Duration: 13 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

.github/CODEOWNERS Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
@ishleenk17
Copy link
Contributor

ishleenk17 commented May 23, 2023

@lalit-satapathy : While updating ownerships in Integrations, I realized that below integrations are under ownership of IM-Integrations.
We should update the same for module as well ?

  1. etcd
  2. coredns

@lalit-satapathy lalit-satapathy marked this pull request as ready for review May 24, 2023 04:07
@lalit-satapathy lalit-satapathy requested a review from a team as a code owner May 24, 2023 04:07
@lalit-satapathy
Copy link
Contributor Author

Opening for additional feedbacks if any.

CC: @joshdover @ruflin @andresrc

.github/CODEOWNERS Outdated Show resolved Hide resolved
@lalit-satapathy
Copy link
Contributor Author

@lalit-satapathy : While updating ownerships in Integrations, I realized that below integrations are under ownership of IM-Integrations. We should update the same for module as well ?

  1. etcd
  2. coredns

etcd is already added and coredns is platforms.

@lalit-satapathy
Copy link
Contributor Author

The plan is to merge this large global changes first and take individual changes separately in future incremental PRs (example: #35545 (comment)). We would like to avoid clubbing all changes to single PR here.

@joshdover, Can we have have someone approve from agent team?

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy lalit-satapathy added the Team:Elastic-Agent Label for the Agent team label Jun 2, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@lalit-satapathy
Copy link
Contributor Author

Ping @elastic/elastic-agent-data-plane for code owner approval.

@lalit-satapathy lalit-satapathy merged commit a818b6d into elastic:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent Label for the Agent team Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants