Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elastic/obs-cloud-monitoring to own cloud-related processors #35459

Merged
merged 2 commits into from
May 15, 2023

Conversation

rdner
Copy link
Member

@rdner rdner commented May 15, 2023

So, the code reviews are assigned properly.

According to @jlind23 the cloud metadata processor belongs to @elastic/obs-cloud-monitoring
and the Kubernetes metadata processors belongs to @elastic/obs-cloudnative-monitoring

I occasionally see PRs that are assigned to the data plane team but they're about internals of these two processors. I think it would be better if the owning teams review them.

I might be wrong about this ownership, if so, please leave a comment.

So, the code reviews are assigned properly.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2023
@botelastic
Copy link

botelastic bot commented May 15, 2023

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned rdner May 15, 2023
@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @rdner? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@rdner rdner requested review from jlind23, a team, gsantoro and MichaelKatsoulis and removed request for a team May 15, 2023 07:53
@rdner rdner marked this pull request as ready for review May 15, 2023 07:53
@rdner rdner requested a review from a team as a code owner May 15, 2023 07:53
@rdner rdner requested a review from ycombinator May 15, 2023 07:53
@jlind23 jlind23 requested a review from a team May 15, 2023 07:55
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-15T07:52:26.326+0000

  • Duration: 12 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Collaborator

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@rdner rdner merged commit 02d313c into main May 15, 2023
@rdner rdner deleted the add-missing-ownership branch May 15, 2023 08:09
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Add `elastic/obs-cloud-monitoring` to own the `add-cloud-metadata` processor
* Add `elastic/obs-cloudnative-monitoring` to own the `add-kubernetes-metadata` processor

So, the code reviews are assigned properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants