-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elastic/obs-cloud-monitoring
to own cloud-related processors
#35459
Conversation
So, the code reviews are assigned properly.
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
* Add `elastic/obs-cloud-monitoring` to own the `add-cloud-metadata` processor * Add `elastic/obs-cloudnative-monitoring` to own the `add-kubernetes-metadata` processor So, the code reviews are assigned properly.
So, the code reviews are assigned properly.
According to @jlind23 the cloud metadata processor belongs to @elastic/obs-cloud-monitoring
and the Kubernetes metadata processors belongs to @elastic/obs-cloudnative-monitoring
I occasionally see PRs that are assigned to the data plane team but they're about internals of these two processors. I think it would be better if the owning teams review them.
I might be wrong about this ownership, if so, please leave a comment.