Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update logging.files.permissions documentation to consider umask #35257

Merged
merged 1 commit into from
May 3, 2023
Merged

[Docs] Update logging.files.permissions documentation to consider umask #35257

merged 1 commit into from
May 3, 2023

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Apr 28, 2023 •
edited
Loading

What does this PR do?

It updates the logging.files.permissions documentation to consider umask as previously done in #28347, but for some reason isn't present in the current docs. The correct is 7.16, but the other versions do not have it. See 7.17, 8.1, main

Why is it important?

Avoid confusion due to missing documentation

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

N/A

Related issues

@AndersonQ AndersonQ added docs Team:Elastic-Agent Label for the Agent team backport-v8.3.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify labels Apr 28, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner April 28, 2023 06:51
@AndersonQ AndersonQ self-assigned this Apr 28, 2023
@AndersonQ AndersonQ requested review from belimawr and fearful-symmetry and removed request for a team April 28, 2023 06:51
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2023
@botelastic
Copy link

botelastic bot commented Apr 28, 2023

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-28T06:51:17.081+0000

  • Duration: 9 min 33 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@AndersonQ AndersonQ merged commit 7524a41 into main May 3, 2023
@AndersonQ AndersonQ deleted the 35256-fix-logging-permission-docs branch May 3, 2023 07:40
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
7aaa1ce 
)

(cherry picked from commit 7524a41)

# Conflicts:
#	filebeat/docs/filebeat-general-options.asciidoc
#	libbeat/docs/loggingconfig.asciidoc
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
51d2ce9 
)

(cherry picked from commit 7524a41)
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
723a337 
)

(cherry picked from commit 7524a41)
@mergify mergify bot mentioned this pull request May 3, 2023
Merged
This was referenced May 3, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
dbfa5bf 
)

(cherry picked from commit 7524a41)
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
37a4dd9 
)

(cherry picked from commit 7524a41)
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
149006a 
)

(cherry picked from commit 7524a41)
This was referenced May 3, 2023
Merged
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 3, 2023
@AndersonQ @mergify
update logging.files.permissions documentation to consider umask (#35257
1cee627 
)

(cherry picked from commit 7524a41)
rdner pushed a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
update logging.files.permissions documentation to consider umask (#35257
55100d1 
) (#35293)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
rdner pushed a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
update logging.files.permissions documentation to consider umask (#35257
cae380e 
) (#35294)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
rdner pushed a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
update logging.files.permissions documentation to consider umask (#35257
5a18bbd 
) (#35295)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
rdner pushed a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
update logging.files.permissions documentation to consider umask (#35257
4ec3e6a 
) (#35296)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
rdner pushed a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
update logging.files.permissions documentation to consider umask (#35257
7d216f4 
) (#35291)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
rdner pushed a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
update logging.files.permissions documentation to consider umask (#35257
ee86e31 
) (#35292)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
AndersonQ added a commit that referenced this pull request May 3, 2023
@AndersonQ
update logging.files.permissions documentation to consider umask (#35257
b1cff43 
)
@AndersonQ AndersonQ mentioned this pull request May 3, 2023
Merged
AndersonQ added a commit that referenced this pull request May 3, 2023
@AndersonQ
update logging.files.permissions documentation to consider umask (#35257
be0eae7 
)
@AndersonQ AndersonQ mentioned this pull request May 3, 2023
Merged
AndersonQ added a commit that referenced this pull request May 3, 2023
@mergify @AndersonQ
[7.17](backport #35257) [Docs] Update logging.files.permissions docum…
1ed3b8a 
…entation to consider umask (#35290)

(cherry picked from commit 7524a41)

Co-authored-by: Anderson Queiroz <[email protected]>
cmacknz pushed a commit that referenced this pull request May 4, 2023
@AndersonQ
[8.1](backport #35257) [Docs] Update logging.files.permissions docume…
0542faa 
…ntation to consider umask (#35304)

* update logging.files.permissions documentation to consider umask (#35257)

* update notice
AndersonQ added a commit that referenced this pull request May 4, 2023
@AndersonQ
[8.2](backport #35257) [Docs] Update logging.files.permissions docume…
393b336 
…ntation to consider umask (#35303)

* update logging.files.permissions documentation to consider umask (#35257)
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@AndersonQ @chrisberkhout
update logging.files.permissions documentation to consider umask (#35257
dd53ead 
)
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@belimawr belimawr belimawr approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@AndersonQ AndersonQ

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify backport-v8.4.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify docs Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Update (again) logging.files.permissions documentation to consider umask
4 participants
@AndersonQ @elasticmachine @belimawr @cmacknz