-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] entityanalytics_azure - Fix accidental error overwrite in defer statement #35169
Merged
taylor-swanson
merged 2 commits into
elastic:main
from
taylor-swanson:issue/35153-ea-oauth2-errors
Apr 21, 2023
Merged
[Filebeat] entityanalytics_azure - Fix accidental error overwrite in defer statement #35169
taylor-swanson
merged 2 commits into
elastic:main
from
taylor-swanson:issue/35153-ea-oauth2-errors
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement - In both the full sync and incremental update functions in Azure AD, a defer statement was always overriding the error value from the function. If an error occurred during the sync/update operation, it would be overwritten by the defer. - Since the error value produced in the defer was not used elsewhere, it is now stored in its own variable - Added additional error information for OAuth2 response - Added test case for error OAuth2 response - Add SEI as codeowner of entityanalytics input
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Apr 21, 2023
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Collaborator
taylor-swanson
requested review from
pierrehilbert and
faec
and removed request for
a team
April 21, 2023 17:10
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
taylor-swanson
changed the title
[entityanalytics_azure] Fix accidental error overwrite in defer statement
[Filebeat] entityanalytics_azure - Fix accidental error overwrite in defer statement
Apr 21, 2023
leehinman
approved these changes
Apr 21, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
…defer statement (#35169) - In both the full sync and incremental update functions in Azure AD, a defer statement was always overriding the error value from the function. If an error occurred during the sync/update operation, it would be overwritten by the defer. - Since the error value produced in the defer was not used elsewhere, it is now stored in its own variable - Added additional error information for OAuth2 response - Added test case for error OAuth2 response - Add SEI as codeowner of entityanalytics input (cherry picked from commit 0807bb8)
taylor-swanson
added a commit
that referenced
this pull request
Apr 21, 2023
…defer statement (#35169) (#35172) - In both the full sync and incremental update functions in Azure AD, a defer statement was always overriding the error value from the function. If an error occurred during the sync/update operation, it would be overwritten by the defer. - Since the error value produced in the defer was not used elsewhere, it is now stored in its own variable - Added additional error information for OAuth2 response - Added test case for error OAuth2 response - Add SEI as codeowner of entityanalytics input (cherry picked from commit 0807bb8) Co-authored-by: Taylor Swanson <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…defer statement (#35169) - In both the full sync and incremental update functions in Azure AD, a defer statement was always overriding the error value from the function. If an error occurred during the sync/update operation, it would be overwritten by the defer. - Since the error value produced in the defer was not used elsewhere, it is now stored in its own variable - Added additional error information for OAuth2 response - Added test case for error OAuth2 response - Add SEI as codeowner of entityanalytics input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
oauth2_test
to test propagation of error values from OAuth2 responseRelated issues
Logs
Error that is now surfaced from original issue: