x-pack/metricbeat/module/statsd: Skip invalid statsd packet(s)

[shmsr]

What does this PR do?

Previously, invalid statsd metric packets would break the ingestion and further metric packets were left unparsed. Now it'd be able to skip invalid packets and continue the parsing. Also made some nitpick fixes (removal of unused vars, usage of proper methods, migrate away from github.com/pkg/errors etc.). Also, made some preallocation changes which are kind of micro-perf improvement and also made did code reorganization to make the code better; although the latter could be done in a different pull request.

Why is it important?

Previously, during parsing of events sent by a statsd client, one invalid packet could stop the entire parsing then and there even if there are valid packets that are waiting to be parsed.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run go tests in the concerned package:

$ go test -v ./...

Related issues

• Relates Invalid statsd message breaks further input processing influxdata/telegraf#11775
• Relates fix(inputs.statsd): Do not error out for parsing errors in datadog mode. influxdata/telegraf#11777

[botelastic]

This pull request doesn't have a Team:<team> label.

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @shmsr? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[shmsr]

While making the changes I'll also found a bug in the statsd's event parser where the parser can't parse all valid values. I'll open an issue. Fix is pretty simple for the same. It's an important one so I'd try to do it ASAP.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-06-14T09:16:00.539+0000

• Duration: 54 min 13 sec

Test stats 🧪

Test	Results
Failed	0
Passed	1501
Skipped	90
Total	1591

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-statsd-skip-invalid-packet-parsing upstream/fix-statsd-skip-invalid-packet-parsing
git merge upstream/main
git push upstream fix-statsd-skip-invalid-packet-parsing

[ritalwar]

LGTM!

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-statsd-skip-invalid-packet-parsing upstream/fix-statsd-skip-invalid-packet-parsing
git merge upstream/main
git push upstream fix-statsd-skip-invalid-packet-parsing

[lucian-ioan]

LGTM!