Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Cisco Meraki module - inverted sport and saddr #35034

Closed

Conversation

pozniako16
Copy link

  • Bug

What does this PR do?

The parsing of the ip:port was for for the source. It just needed to be inverted

Why is it important?

It was breaking the parsing of the meraki logs and it could not be displayed correctly in elastic

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

  • Closes # 35025

Use cases

Screenshots

Logs

@pozniako16 pozniako16 requested a review from a team as a code owner April 6, 2023 06:43
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 6, 2023
@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
843098b

Please, read and sign the above mentioned agreement if you want to contribute to this project

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pozniako16? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T06:43:20.140+0000

  • Duration: 5 min 41 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/beats.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/pozniako16 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/pozniako16 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/pozniako16 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pozniako16? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@andrewkroh andrewkroh added Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Feb 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 6, 2024
@andrewkroh andrewkroh added the bug label Feb 6, 2024
@andrewkroh andrewkroh changed the title inverted sport and saddr [Filebeat] Cisco Meraki module - inverted sport and saddr Feb 6, 2024
@andrewkroh
Copy link
Member

This is a change for the deprecated cisco meraki module (see #36125) for details. It is planned for full removal in 8.14 so we are not going to fix it. We have a fully supported pipeline for Meraki in https://docs.elastic.co/integrations/cisco_meraki.

@andrewkroh andrewkroh closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants