-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Remove unused/underused API from the beats feature package #34974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faec
requested review from
ycombinator and
leehinman
and removed request for
a team
March 30, 2023 11:13
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 30, 2023
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 30, 2023
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Collaborator
leehinman
approved these changes
Mar 30, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely an internal cleanup, it should have no functional change.
Most of the code in
libbeat/feature
is unused. That package defines a global registry of plugins and features that lets callers register arbitrary factories that can be queried under appropriate namespaces. It was originally intended as an interim step in library migration (see the somewhat poignant 5-year-old comment// Registry is the global plugin registry, this variable is meant to be temporary...
), but many of its features were never used and after some recent cleanups its only remaining client is Functionbeat (which still only uses a small part of its functionality, relying mostly on functionbeat-specific extensions inx-pack/functionbeat/function/provider
).This PR removes the unused parts of the package and clarifies/simplifies the code that is still used. A reasonable followup might be to move the remaining API entirely into Functionbeat, which has unique use cases for it that have grown beyond the original package, however I wanted to do an in-place cleanup first to simplify code review.