-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Metrics] Fix CassandraConnectionClosures metric configuration #34742
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
5edfd50
to
1cff909
Compare
/test |
This pull request is now in conflicts. Could you fix it? 🙏
|
1 similar comment
This pull request is now in conflicts. Could you fix it? 🙏
|
The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true.
The `CassandraConnectionClosures` metric only supports the following dimensions: - `ClosureReason` - `Region`
1cff909
to
d28f3e0
Compare
…34742) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true. * Update changelog * Fix dimensions for CassandraConnectionClosures The `CassandraConnectionClosures` metric only supports the following dimensions: - `ClosureReason` - `Region` (cherry picked from commit 42f2f94)
…34742) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true. * Update changelog * Fix dimensions for CassandraConnectionClosures The `CassandraConnectionClosures` metric only supports the following dimensions: - `ClosureReason` - `Region` (cherry picked from commit 42f2f94)
…34742) (#36921) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true. * Update changelog * Fix dimensions for CassandraConnectionClosures The `CassandraConnectionClosures` metric only supports the following dimensions: - `ClosureReason` - `Region` (cherry picked from commit 42f2f94) Co-authored-by: Maurizio Branca <[email protected]>
…es metric configuration (#36920) * [Azure Metrics] Fix CassandraConnectionClosures metric configuration (#34742) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true. * Update changelog * Fix dimensions for CassandraConnectionClosures The `CassandraConnectionClosures` metric only supports the following dimensions: - `ClosureReason` - `Region` (cherry picked from commit 42f2f94) * Remove extra changelog entries * Remove extra empty line --------- Co-authored-by: Maurizio Branca <[email protected]>
…lastic#34742) * Move CassandraConnectionClosures metrics The name of the metric, "CassandraConnectionClosures" is listed in the wrong section of the metrics configuration. It should be moved to a different section that includes metric names which may or may not be available depending on the environment, with the "ignore_unsupported" setting set to true. * Update changelog * Fix dimensions for CassandraConnectionClosures The `CassandraConnectionClosures` metric only supports the following dimensions: - `ClosureReason` - `Region`
What does this PR do?
Move the
CassandraConnectionClosures
metric name from the always-available list of metrics to the Cassandra-focused list of metrics.Metric names not always available should be listed in a section marked with the ignore_unsupported setting set to
true
.Why is it important?
The integration works if the subscription has at least one Cassandra cluster available but fails otherwise.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentationCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues