Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Fix tracking http url parsing error #34702

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Feb 28, 2023

What does this PR do?

Fixes panics when http url is not parseable:

"[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x560c665b2eef]"
"goroutine 58 [running]:"
"github.com/elastic/beats/v7/heartbeat/monitors/wrappers.URLFields(0x0)"
"github.com/elastic/beats/v7/heartbeat/monitors/wrappers/util.go:56 +0x2f"

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Configure an http monitor with urls: [" "]

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.7.0 labels Feb 28, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner February 28, 2023 20:38
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 28, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@emilioalvap emilioalvap added the backport-skip Skip notification from the automated backport with mergify label Feb 28, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-01T09:55:50.201+0000

  • Duration: 49 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 1921
Skipped 25
Total 1946

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏽

@emilioalvap emilioalvap merged commit 9d834d1 into elastic:main Mar 1, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Fix tracking http url parsing error

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants