Report FQDN on host.name enabled by a feature flag #34456

AndersonQ · 2023-02-02T09:58:03Z

What does this PR do?

This PR enhances Beats to accept feature flag configuration either in standalone or managed mode. It also enhances Beats to report their host's FQDN when the FQDN feature flag is set.

For Beats running in standalone mode, feature flag configuration is defined in the <beat>.yml configuration file as follows:

features:
  <flagname>:
    enabled: true

For example, to run Metricbeat standalone with the FQDN feature flag enabled, configure the following section in metricbeat.yml:

features:
  fqdn:
    enabled:  true

Why is it important?

To enable use cases, particularly involving running multiple Beats in a containerized environment, where it's useful for every Beat to report it's host's FQDN.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

Effect on `add_host_metadata` processor

With FQDN feature flag disabled

beats_standalone_add_host_metadata_fqdn_disabled.mov

With FQDN feature flag enabled

beats_standalone_add_host_metadata_fqdn_enabled.mov

Effect on `http.enabled: true` setting

With FQDN feature flag disabled

beats_standalone_http_enabled_fqdn_disabled.mov

With FQDN feature flag enabled

beats_standalone_http_enabled_fqdn_enabled.mov

How to test this PR locally

See screen recordings in previous section.

Related issues

Closes Report host name as FQDN on all platforms #1070

Use cases

Screenshots

Logs

mergify · 2023-02-02T09:58:39Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AndersonQ? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2023-02-02T10:04:38Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-03-20T12:40:57.801+0000
Duration: 135 min 37 sec

Test stats 🧪

Test	Results
Failed	0
Passed	26021
Skipped	1968
Total	27989

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz · 2023-02-08T19:20:54Z

There are a few other references to the host.name field besides just the one in add_host_metadata.

rg '"host.name"' -g '!*_test.go' -g '!*.py' -g '!*.json' will find them using ripgrep.

libbeat/processors/decode_xml_wineventlog/processor.go
libbeat/processors/add_host_metadata/add_host_metadata.go
libbeat/docs/troubleshooting/default_field.md
x-pack/filebeat/module/imperva/securesphere/config/liblogparser.js
x-pack/filebeat/module/fortinet/clientendpoint/config/liblogparser.js
x-pack/filebeat/module/fortinet/fortimanager/config/liblogparser.js
x-pack/filebeat/module/fortinet/fortimail/config/liblogparser.js
x-pack/filebeat/module/snort/log/config/liblogparser.js
x-pack/filebeat/module/infoblox/nios/config/liblogparser.js
x-pack/filebeat/module/radware/defensepro/config/liblogparser.js
x-pack/metricbeat/module/aws/cloudwatch/metadata/ec2/ec2.go
x-pack/filebeat/module/sophos/utm/config/liblogparser.js
x-pack/filebeat/module/juniper/junos/config/liblogparser.js
x-pack/filebeat/module/juniper/netscreen/config/liblogparser.js
x-pack/filebeat/module/zeek/dhcp/test/dhcp-json.log
x-pack/filebeat/module/o365/audit/config/pipeline.js
x-pack/filebeat/module/sonicwall/firewall/config/liblogparser.js
x-pack/filebeat/module/bluecoat/director/config/liblogparser.js
x-pack/filebeat/module/netscout/sightline/config/liblogparser.js
x-pack/filebeat/module/barracuda/waf/config/liblogparser.js
x-pack/filebeat/module/barracuda/spamfirewall/config/liblogparser.js
x-pack/filebeat/module/cisco/nexus/config/liblogparser.js
x-pack/filebeat/module/cisco/meraki/config/liblogparser.js
x-pack/filebeat/module/f5/bigipafm/config/liblogparser.js
x-pack/filebeat/module/proofpoint/emailsecurity/config/liblogparser.js
x-pack/filebeat/module/f5/bigipapm/config/liblogparser.js
x-pack/filebeat/module/microsoft/dhcp/config/liblogparser.js
x-pack/filebeat/module/squid/log/config/liblogparser.js
x-pack/filebeat/module/tomcat/log/config/liblogparser.js
x-pack/metricbeat/module/gcp/metrics/metricset.go
x-pack/filebeat/module/crowdstrike/falcon/ingest/firewall_match.yml
x-pack/filebeat/module/zscaler/zia/config/liblogparser.js
x-pack/metricbeat/module/azure/add_metadata.go
x-pack/filebeat/module/cylance/protect/config/liblogparser.js
winlogbeat/eventlog/eventlog.go
metricbeat/module/beat/state/data.go

cmacknz · 2023-02-08T20:29:25Z

It appears that the Windows event logs might be the FQDN by default. We should explicitly try to test and inspect the host.name value for each path in Beats that sets it to ensure it is consistent everywhere.

mergify · 2023-02-09T16:49:20Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 1070-fqdn-feature-flag upstream/1070-fqdn-feature-flag
git merge upstream/main
git push upstream 1070-fqdn-feature-flag

AndersonQ · 2023-02-20T08:08:31Z

There are a few other references to the host.name field besides just the one in add_host_metadata.

rg '"host.name"' -g '!*_test.go' -g '!*.py' -g '!*.json' will find them using ripgrep.

libbeat/processors/decode_xml_wineventlog/processor.go
libbeat/processors/add_host_metadata/add_host_metadata.go
libbeat/docs/troubleshooting/default_field.md
x-pack/filebeat/module/imperva/securesphere/config/liblogparser.js
x-pack/filebeat/module/fortinet/clientendpoint/config/liblogparser.js
x-pack/filebeat/module/fortinet/fortimanager/config/liblogparser.js
x-pack/filebeat/module/fortinet/fortimail/config/liblogparser.js
x-pack/filebeat/module/snort/log/config/liblogparser.js
x-pack/filebeat/module/infoblox/nios/config/liblogparser.js
x-pack/filebeat/module/radware/defensepro/config/liblogparser.js
x-pack/metricbeat/module/aws/cloudwatch/metadata/ec2/ec2.go
x-pack/filebeat/module/sophos/utm/config/liblogparser.js
x-pack/filebeat/module/juniper/junos/config/liblogparser.js
x-pack/filebeat/module/juniper/netscreen/config/liblogparser.js
x-pack/filebeat/module/zeek/dhcp/test/dhcp-json.log
x-pack/filebeat/module/o365/audit/config/pipeline.js
x-pack/filebeat/module/sonicwall/firewall/config/liblogparser.js
x-pack/filebeat/module/bluecoat/director/config/liblogparser.js
x-pack/filebeat/module/netscout/sightline/config/liblogparser.js
x-pack/filebeat/module/barracuda/waf/config/liblogparser.js
x-pack/filebeat/module/barracuda/spamfirewall/config/liblogparser.js
x-pack/filebeat/module/cisco/nexus/config/liblogparser.js
x-pack/filebeat/module/cisco/meraki/config/liblogparser.js
x-pack/filebeat/module/f5/bigipafm/config/liblogparser.js
x-pack/filebeat/module/proofpoint/emailsecurity/config/liblogparser.js
x-pack/filebeat/module/f5/bigipapm/config/liblogparser.js
x-pack/filebeat/module/microsoft/dhcp/config/liblogparser.js
x-pack/filebeat/module/squid/log/config/liblogparser.js
x-pack/filebeat/module/tomcat/log/config/liblogparser.js
x-pack/metricbeat/module/gcp/metrics/metricset.go
x-pack/filebeat/module/crowdstrike/falcon/ingest/firewall_match.yml
x-pack/filebeat/module/zscaler/zia/config/liblogparser.js
x-pack/metricbeat/module/azure/add_metadata.go
x-pack/filebeat/module/cylance/protect/config/liblogparser.js
winlogbeat/eventlog/eventlog.go
metricbeat/module/beat/state/data.go

luckily the huge majority of these files are the same, liblogparser.js, and so far I don't think we'll need to modify them.

There is indeed a few places that indeed use a different approach to populate host.name and winlogbeat is one of them.

ycombinator · 2023-03-07T01:22:41Z

winlogbeat/sys/wineventlog/renderer.go

@@ -222,6 +222,7 @@ func (r *Renderer) renderSystem(handle EvtHandle, event *winevent.Event) error {
 			event.Channel = data.(string)
 		case EvtSystemComputer:
 			event.Computer = data.(string)
+			// TODO: set event.Computer to FQDN if features.FQDN() is true?


@efd6 @andrewkroh In this PR we're trying to set host.name in events generated by Beats to the FQDN if the Beat config contains features.fqdn.enabled: true. What's the best way to retrieve the FQDN on a Windows host? I assume this is the line in code where we'd want to set event.Computer to the FQDN if the feature is enabled?

First, a little background on where this event.Computer value comes from... I think the way Windows event log records work is that each event log record contains a ComputerName value that is determined at the time the event is generated. If the computer is not a member of a Active Directory domain when the log is written then it gets recorded with a short hostname (e.g. mymachine). If the computer is a member of an AD domain then it gets recorded as <hostname>.<ad-domain-name> (e.g. mymachine.company.com).

And be aware that the event log reader can read archived .evtx files that may have originated on a different machine (with a different hostname that the reader). Similarly event log records can be forwarded from one host to another and in this case they will have the source machine's hostname (or <hostname>.<domain> if it was a domain member).

For data integrity purposes I think we will want to keep the winlog.computer_name field exactly as it was in the source event log record. That value is copied directly into host.name so that is probably the location where we need to make some changes/decisions.

beats/winlogbeat/eventlog/eventlog.go

Line 101 in 34a87e5

winevent.AddOptional(m, "host.name", e.Computer)

Perhaps we let add_host_metadata overwrite the host.name value with the appropriate host name value based on the features. Could make an exception for when the data is forwarded from another host or the data is read from an archived log? This is similar to what we tried to achieve in the default winlogbeat.yml config except I don't think this config overwrites the host.name value that was set from the ComputerName.

beats/winlogbeat/winlogbeat.yml

Lines 139 to 140 in cbd1a38

- add_host_metadata:

when.not.contains.tags: forwarded

In the case of forwarded logs or logs read from an .evtx file, should we try and normalize the value? For example if features.fqdn.enabled=false then do we try to trim the domain suffix if it is present in the event log's ComputerName?

Thanks for the background and suggestions, @andrewkroh. I've created a separate issue to handle FQDN reporting for Windows hosts, as the use case urgently driving the FQDN feature implementation is for Beats running in containerized environments, which tend to be *nix most of the times. I've created #34782 to follow up on implementing FQDN reporting for Windows hosts.

Do we need to keep this TODO in the code? From our previous discussion I believe we concluded we likely don't need to touch this.

Good catch, we don't need this TODO any more. Removing...

mergify · 2023-03-08T02:35:13Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 1070-fqdn-feature-flag upstream/1070-fqdn-feature-flag
git merge upstream/main
git push upstream 1070-fqdn-feature-flag

ycombinator · 2023-03-08T14:49:51Z

@cmacknz Thanks for posting the rg command. I re-ran it, but also excluded files under Beat module folders and *.md files, and here' what comes up:

$ rg '"host.name"' -g '!*_test.go' -g '!*.py' -g '!*.json' -g '!*.md' -g '!**/*beat/module/**'
winlogbeat/eventlog/eventlog.go
101:	winevent.AddOptional(m, "host.name", e.Computer)

libbeat/processors/decode_xml_wineventlog/processor.go
149:	winevent.AddOptional(ecs, "host.name", evt.Computer)

libbeat/processors/add_host_metadata/add_host_metadata.go
152:		data.Put("host.name", p.config.Name)

For the first two results, related to hostnames on Windows, I'll follow up in #34456 (comment).

That leaves the last result, related to the add_host_metadata processor. This area has already been addressed in this PR.

Additionally, not seen in the rg results, there is also the hostname reported by the GET / and GET /state Beats HTTP APIs, which are called by the beat Metricbeat module, which Agent uses for monitoring it's component Beats' health. This area has also been addressed in this PR.

cmacknz · 2023-03-21T17:53:13Z

x-pack/libbeat/management/managerV2.go

 		}
-		if state == client.UnitStateStopped {
+		if expected.Features != nil {


Do we disable the feature if expected.Features == nil and the current Features configuration is not nil? Is this a case you need to handle, or does the agent always provided a non-nil Features in expected?

In the beginning, before any feature flags are set, Agent will send a nil value for expected.Features. So this check here guards against that condition, preventing any unnecessary processing. Thereafter, whenever a feature flag gets set, Agent will only send non-nil values for expected.Features; see https://github.com/elastic/elastic-agent/pull/2218/files#diff-5570d8d3d94d053efb7e59bcad53e531bcf3a0ff5b8d3da9cc3334d859f095c9R176-R181

Since expected.Features is built to contain multiple features' configuration in it, we would only disable a feature if that particular feature's configuration within expected.Features indicated as such. For example, if expected.Features.FQDN.Enabled was set to false. AFAIU we have not designed for a use case of mass-disabling all features by setting expecting.Features to nil.

AFAIU we have not designed for a use case of mass-disabling all features by setting expecting.Features to nil.

That doesn't mean someone won't make that edit in the policy. IMO the most obvious thing to do is to translate that to disabling all features, that maps to what happens when you remove an input from the policy. We can file a follow up issue to deal with this, it is definitely an edge case.

* wip * wip * wip * something is broken * debug logs * avoid panics * wip broken * wip - perhaps fixed double configuring features * using triggers to know what changed * it works, but the agent-client is sending feature changes every time * debug logs * more debug logs * wip * it works * remove debug logs * fix after rebase * update elastic-agent-client and make notice * license headres * Add TODO for Winlogbeat FQDN implementation * Removing unnecesary code * Use RWMutex for greater read efficiency * Move mutex inside struct * Better error handling * Temporarily updating dependency * Always store FQDN in Beat info * Set hostname in monitoring registries after FQDN config has been evaluated * Pass down FQDN flag from add_host_metadata processor * Better error handling * Add temporary notice override * Changing log level * Update dependency on elastic-agent-system-metrics * Running go mod tidy * Update elastic-agent-system-metrics dependency version * Add feature flags configuration section to reference yml * Bump up version of elastic-agent-client depdendency * Updating reference file * Updating reference files * Move feature flags setting into same method where log level setting is handled * Updating docs * Adding CHANGELOG entry * Remove replace directive for go-sysinfo * Running go mod tidy * Remove replace directive for elastic-agent-client dependency * Remove personal repos from overrides.json * Updating NOTICE * Bump up version for elastic-agent-client dependency * Update NOTICE * Removing noisy debug logging * Removing commented out code that's not needed * Fixing error message * Make default flag setting more explicit * Adding config with no features to unit test * Add helper method to beat.Info for returning FQDN-aware hostname * Adding license header to test file * Remove use of errors package * Check error from data.Put * Expire add_host_metadata cache immediately on FQDN feature flag value change * Fix casing in error message * Have callback registration function accept ID * Fixing go formatting * Account for feature flags in TestManagerV2 test * Update logging for unit changes * Remove TODO from wineventlog code * Updating dependency * Include shared file in docs * Bumping dependency on elastic-agent-client * Include features config in diagnostics output * Update comment * Updating NOTICE * Re-formatting * Running make update --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit faf4c11) # Conflicts: # go.mod # go.sum

…flag (#34860) * Report FQDN on host.name enabled by a feature flag (#34456) * wip * wip * wip * something is broken * debug logs * avoid panics * wip broken * wip - perhaps fixed double configuring features * using triggers to know what changed * it works, but the agent-client is sending feature changes every time * debug logs * more debug logs * wip * it works * remove debug logs * fix after rebase * update elastic-agent-client and make notice * license headres * Add TODO for Winlogbeat FQDN implementation * Removing unnecesary code * Use RWMutex for greater read efficiency * Move mutex inside struct * Better error handling * Temporarily updating dependency * Always store FQDN in Beat info * Set hostname in monitoring registries after FQDN config has been evaluated * Pass down FQDN flag from add_host_metadata processor * Better error handling * Add temporary notice override * Changing log level * Update dependency on elastic-agent-system-metrics * Running go mod tidy * Update elastic-agent-system-metrics dependency version * Add feature flags configuration section to reference yml * Bump up version of elastic-agent-client depdendency * Updating reference file * Updating reference files * Move feature flags setting into same method where log level setting is handled * Updating docs * Adding CHANGELOG entry * Remove replace directive for go-sysinfo * Running go mod tidy * Remove replace directive for elastic-agent-client dependency * Remove personal repos from overrides.json * Updating NOTICE * Bump up version for elastic-agent-client dependency * Update NOTICE * Removing noisy debug logging * Removing commented out code that's not needed * Fixing error message * Make default flag setting more explicit * Adding config with no features to unit test * Add helper method to beat.Info for returning FQDN-aware hostname * Adding license header to test file * Remove use of errors package * Check error from data.Put * Expire add_host_metadata cache immediately on FQDN feature flag value change * Fix casing in error message * Have callback registration function accept ID * Fixing go formatting * Account for feature flags in TestManagerV2 test * Update logging for unit changes * Remove TODO from wineventlog code * Updating dependency * Include shared file in docs * Bumping dependency on elastic-agent-client * Include features config in diagnostics output * Update comment * Updating NOTICE * Re-formatting * Running make update --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit faf4c11) # Conflicts: # go.mod # go.sum * Remove conflict markers * Updating NOTICE.txt * Fixing dependency versions * Fix CHANGELOG --------- Co-authored-by: Anderson Queiroz <[email protected]> Co-authored-by: Shaunak Kashyap <[email protected]>

* wip * wip * wip * something is broken * debug logs * avoid panics * wip broken * wip - perhaps fixed double configuring features * using triggers to know what changed * it works, but the agent-client is sending feature changes every time * debug logs * more debug logs * wip * it works * remove debug logs * fix after rebase * update elastic-agent-client and make notice * license headres * Add TODO for Winlogbeat FQDN implementation * Removing unnecesary code * Use RWMutex for greater read efficiency * Move mutex inside struct * Better error handling * Temporarily updating dependency * Always store FQDN in Beat info * Set hostname in monitoring registries after FQDN config has been evaluated * Pass down FQDN flag from add_host_metadata processor * Better error handling * Add temporary notice override * Changing log level * Update dependency on elastic-agent-system-metrics * Running go mod tidy * Update elastic-agent-system-metrics dependency version * Add feature flags configuration section to reference yml * Bump up version of elastic-agent-client depdendency * Updating reference file * Updating reference files * Move feature flags setting into same method where log level setting is handled * Updating docs * Adding CHANGELOG entry * Remove replace directive for go-sysinfo * Running go mod tidy * Remove replace directive for elastic-agent-client dependency * Remove personal repos from overrides.json * Updating NOTICE * Bump up version for elastic-agent-client dependency * Update NOTICE * Removing noisy debug logging * Removing commented out code that's not needed * Fixing error message * Make default flag setting more explicit * Adding config with no features to unit test * Add helper method to beat.Info for returning FQDN-aware hostname * Adding license header to test file * Remove use of errors package * Check error from data.Put * Expire add_host_metadata cache immediately on FQDN feature flag value change * Fix casing in error message * Have callback registration function accept ID * Fixing go formatting * Account for feature flags in TestManagerV2 test * Update logging for unit changes * Remove TODO from wineventlog code * Updating dependency * Include shared file in docs * Bumping dependency on elastic-agent-client * Include features config in diagnostics output * Update comment * Updating NOTICE * Re-formatting * Running make update --------- Co-authored-by: Shaunak Kashyap <[email protected]>

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 2, 2023

mergify bot assigned AndersonQ Feb 2, 2023

AndersonQ force-pushed the 1070-fqdn-feature-flag branch 2 times, most recently from f22ab3e to 7338984 Compare February 28, 2023 17:31

endorama added the Team:Elastic-Agent Label for the Agent team label Mar 1, 2023

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 1, 2023

AndersonQ force-pushed the 1070-fqdn-feature-flag branch from 79506a8 to 8ce8fb0 Compare March 1, 2023 21:36

ycombinator force-pushed the 1070-fqdn-feature-flag branch from 8ce8fb0 to d36e29d Compare March 7, 2023 00:55

ycombinator reviewed Mar 7, 2023

View reviewed changes

ycombinator force-pushed the 1070-fqdn-feature-flag branch 2 times, most recently from 1fa2caa to 3548c07 Compare March 7, 2023 16:29

ycombinator mentioned this pull request Mar 7, 2023

Make host metrics reporting FQDN-aware elastic/elastic-agent-system-metrics#75

Merged

4 tasks

ycombinator force-pushed the 1070-fqdn-feature-flag branch from 26c38ad to 053ed7a Compare March 8, 2023 15:07

ycombinator marked this pull request as ready for review March 8, 2023 20:34

ycombinator requested review from a team as code owners March 8, 2023 20:34

ycombinator requested review from belimawr and leehinman and removed request for a team March 8, 2023 20:34

ycombinator added 13 commits March 20, 2023 08:40

Have callback registration function accept ID

7520fac

Fixing go formatting

cd8f901

Account for feature flags in TestManagerV2 test

a7e4145

Update logging for unit changes

542d54a

Remove TODO from wineventlog code

70f654f

Updating dependency

1a82458

Include shared file in docs

4757a5a

Bumping dependency on elastic-agent-client

77772ca

Include features config in diagnostics output

66a748c

Update comment

fd09ab8

Updating NOTICE

4444a16

Re-formatting

4a4b223

Running make update

b0e457f

ycombinator force-pushed the 1070-fqdn-feature-flag branch from 454e4b0 to b0e457f Compare March 20, 2023 12:40

Merge branch 'main' into 1070-fqdn-feature-flag

920a61e

ycombinator merged commit faf4c11 into elastic:main Mar 20, 2023

mergify bot mentioned this pull request Mar 20, 2023

[8.7](backport #34456) Report FQDN on host.name enabled by a feature flag #34860

Merged

cmacknz reviewed Mar 21, 2023

View reviewed changes

ycombinator mentioned this pull request Mar 22, 2023

Adding convenience method for FQDN-aware hostname elastic/elastic-agent-libs#108

Closed

4 tasks

ycombinator mentioned this pull request Mar 28, 2023

Log any FQDN lookup errors and fallback to OS-reported hostname #34946

Merged

6 tasks

ycombinator mentioned this pull request Apr 3, 2023

Add Feature Flag page with new FQDN setting elastic/observability-docs#2817

Merged

kilfoyle mentioned this pull request Apr 3, 2023

Add detail for fqdn feature docs #34999

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report FQDN on host.name enabled by a feature flag #34456

Report FQDN on host.name enabled by a feature flag #34456

AndersonQ commented Feb 2, 2023 •

edited by ycombinator

Loading

mergify bot commented Feb 2, 2023

elasticmachine commented Feb 2, 2023 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

cmacknz commented Feb 8, 2023 •

edited

Loading

cmacknz commented Feb 8, 2023

mergify bot commented Feb 9, 2023

AndersonQ commented Feb 20, 2023

ycombinator Mar 7, 2023

andrewkroh Mar 7, 2023

ycombinator Mar 8, 2023

cmacknz Mar 10, 2023

ycombinator Mar 10, 2023

mergify bot commented Mar 8, 2023

ycombinator commented Mar 8, 2023

cmacknz Mar 21, 2023

ycombinator Mar 21, 2023

cmacknz Mar 24, 2023

Report FQDN on host.name enabled by a feature flag #34456

Report FQDN on host.name enabled by a feature flag #34456

Conversation

AndersonQ commented Feb 2, 2023 • edited by ycombinator Loading

What does this PR do?

Why is it important?

Checklist

Author's Checklist

Effect on add_host_metadata processor

With FQDN feature flag disabled

With FQDN feature flag enabled

Effect on http.enabled: true setting

With FQDN feature flag disabled

With FQDN feature flag enabled

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

mergify bot commented Feb 2, 2023

elasticmachine commented Feb 2, 2023 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

cmacknz commented Feb 8, 2023 • edited Loading

cmacknz commented Feb 8, 2023

mergify bot commented Feb 9, 2023

AndersonQ commented Feb 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Mar 8, 2023

ycombinator commented Mar 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndersonQ commented Feb 2, 2023 •

edited by ycombinator

Loading

Effect on `add_host_metadata` processor

Effect on `http.enabled: true` setting

elasticmachine commented Feb 2, 2023 •

edited by jenkins-beats-ci bot

Loading

cmacknz commented Feb 8, 2023 •

edited

Loading