-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Google Cloud Storage] Add support for alternative_host for system tests #34413
Conversation
…TTP client for system tests
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
…tive_host for system tests (#34415) * [Google Cloud Storage] Add support for alternative_host for system tests (#34413) * [Google Cloud Storage] Add support for alternative_host to override HTTP client for system tests * update changelog (cherry picked from commit d1ef41c) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Marius Iversen <[email protected]>
…sts (#34413) * [Google Cloud Storage] Add support for alternative_host to override HTTP client for system tests * update changelog
What does this PR do?
This adds the
alternative_host
option, which is a field only used for internal testing. By default the input only reaches out to the public cloud GCS API, and this allows us to override this and instead point it to our own emulator running locally for system tests.Why is it important?
Required for adding system tests for elastic-agent integration packages.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
docker run -p 4443:4443 fsouza/fake-gcs-server -host="0.0.0.0" -public-host=localhost -port=4443 -scheme=http
go build
:https://github.com/elastic/stream
test.json
, add a JSON object on a single line, like{ "testmessage" : "success" }
stream
:./stream log --retry=30 --addr=http://localhost:4443 -p gcs --gcs-content-type="application/json" ./test.json
filebeat
with followingfilebeat.yml
The expected result is that a the object is retrieved and that
parse_json
works as expected