Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pytest versions and pytest_otel #34303

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

kuisathaverat
Copy link
Contributor

What does this PR do?

  • It bumps pytest_otel to 1.3.0
  • It bumps pytest to 7.1.3
  • It bumps Otel Python SDK to 1.13

Why is it important?

There is an issue with Otel Python SDK 1.11 running on Python 3.10+ see open-telemetry/opentelemetry-python#2288

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd x-pack/auditbeat
mage build test

Related issues

related to #33863 elastic/apm-pipeline-library#1969

@kuisathaverat kuisathaverat added bug Team:Automation Label for the Observability productivity team labels Jan 18, 2023
@kuisathaverat kuisathaverat requested review from andrewkroh and a team January 18, 2023 11:00
@kuisathaverat kuisathaverat self-assigned this Jan 18, 2023
@kuisathaverat kuisathaverat requested a review from a team as a code owner January 18, 2023 11:00
@kuisathaverat kuisathaverat requested review from faec and leehinman and removed request for a team January 18, 2023 11:00
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kuisathaverat? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-24T07:56:03.991+0000

  • Duration: 68 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 25276
Skipped 1958
Total 27234

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh
Copy link
Member

Looks like there is an issue with the virtualenv requirements.

>> python test: Unit Testing
ERROR: Could not find a version that satisfies the requirement opentelemetry-api==1.13.0 (from versions: 0.1a0, 0.2a0, 0.3a0, 0.4a0, 0.4a1, 0.5b0, 0.6b0, 0.7b0, 0.7b1, 0.8b0, 0.9b0, 0.10b0, 0.11b0, 0.12b0, 0.13b0, 0.14b0, 0.15b0, 0.16b0, 0.16b1, 0.17b0, 1.0.0rc1, 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.4.1, 1.5.0, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.8.0, 1.9.0, 1.9.1, 1.10a0, 1.10.0, 1.11.0, 1.11.1, 1.12.0rc1, 1.12.0rc2, 1.12.0)

@kuisathaverat
Copy link
Contributor Author

kuisathaverat commented Jan 19, 2023

@andrewkroh Ubuntu 18.04 workers have Python 3.6, and Python OpenTelemetry SDK removed support for Python 3.6 in the version 1.13

Solutions are bump Ubuntu 18.04 workers to 20.04 or 22.04 or remove pytest_otel. WDYT @v1v?

Screenshot 2023-01-19 at 10 20 12

@v1v
Copy link
Member

v1v commented Jan 19, 2023

Solutions are bump Ubuntu 18.04 workers to 20.04 or 22.04 or remove pytest_otel. WDYT @v1v?

I'd be inclined to use ubuntu:22 if possible, let me put a couple of PRs for both OSes so we can then test they work as expected

This was referenced Jan 19, 2023
@andrewkroh
Copy link
Member

If ubuntu 22.04 is passing for everything then that SGTM. We can add a new OS column to a support matrix for Beats too 😄 .

@v1v
Copy link
Member

v1v commented Jan 24, 2023

#34355 has been merged hence this PR will be ready to give another go :) I'll update the branch with the above button

@kuisathaverat
Copy link
Contributor Author

The CI pass, @andrewkroh Are you OK to merge?

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuisathaverat kuisathaverat merged commit 88b3e96 into elastic:main Jan 24, 2023
@kuisathaverat
Copy link
Contributor Author

The issue is still present in the ARM workers. We have to bump the Python version in those workers too

@v1v
Copy link
Member

v1v commented Jan 26, 2023

I guess we won't backport this to 8.6 and 7.17, so I'll then close the ones that were opened for the ubuntu-22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants