-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update pytest versions and pytest_otel #34303
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Looks like there is an issue with the virtualenv requirements.
|
@andrewkroh Ubuntu 18.04 workers have Python 3.6, and Python OpenTelemetry SDK removed support for Python 3.6 in the version 1.13 Solutions are bump Ubuntu 18.04 workers to 20.04 or 22.04 or remove pytest_otel. WDYT @v1v? |
I'd be inclined to use |
If ubuntu 22.04 is passing for everything then that SGTM. We can add a new OS column to a support matrix for Beats too 😄 . |
#34355 has been merged hence this PR will be ready to give another go :) I'll update the branch with the above button |
The CI pass, @andrewkroh Are you OK to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The issue is still present in the ARM workers. We have to bump the Python version in those workers too |
I guess we won't backport this to 8.6 and 7.17, so I'll then close the ones that were opened for the ubuntu-22 |
Co-authored-by: Victor Martinez <[email protected]>
What does this PR do?
Why is it important?
There is an issue with Otel Python SDK 1.11 running on Python 3.10+ see open-telemetry/opentelemetry-python#2288
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues
related to #33863 elastic/apm-pipeline-library#1969