Improve template testing #3425
Merged
Improve template testing #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template tests broke in the past several times because we have a test template which is not updated automatically. The tests are now changed so that the libbeat template is generated and tested. This guarantees that the templates we actually use are tested. This requires for integration tests also for libbeat to be called `make update`. * Switch to `update` also for libbeat. * Files generated by `update` are added go `.gitignore` as these files should not be versioned. * Add heartbeat to template tests * Remove static test templates as not needed anymore.
ruflin
force-pushed
the
template-improvements
branch
from
17602be to
d5e91a1
Compare
ruflin
added
review
and removed
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template tests broke in the past several times because we have a test template which is not updated automatically. The tests are now changed so that the libbeat template is generated and tested. This guarantees that the templates we actually use are tested. This requires for integration tests also for libbeat to be called
make update.updatealso for libbeat.updateare added go.gitignoreas these files should not be versioned.