Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricbeat] [gcp] fix regions feature changelog entry #33716

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Nov 17, 2022

What does this PR do?

PR (#32964) added a changelog entry in CHANGELOG-developer.next, it should have been added in CHANGELOG-next.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 17, 2022
@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 17, 2022
@mergify mergify bot assigned gpop63 Nov 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gpop63? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 17, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T13:23:54.504+0000

  • Duration: 8 min 26 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gpop63 gpop63 marked this pull request as ready for review November 23, 2022 20:48
@endorama endorama added backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix_gcp-regions_changelog upstream/fix_gcp-regions_changelog
git merge upstream/main
git push upstream fix_gcp-regions_changelog

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@endorama endorama merged commit 97a76bc into elastic:main Dec 2, 2022
mergify bot pushed a commit that referenced this pull request Dec 2, 2022
mergify bot pushed a commit that referenced this pull request Dec 2, 2022
endorama added a commit that referenced this pull request Dec 21, 2022
…og entry (#33927)

* [metricbeat] [gcp] fix regions feature changelog entry (#33716)

(cherry picked from commit 97a76bc)

* Update CHANGELOG.next.asciidoc

Co-authored-by: Gabriel Pop <[email protected]>
Co-authored-by: Edoardo Tenani <[email protected]>
endorama added a commit that referenced this pull request Dec 21, 2022
…og entry (#33926)

* [metricbeat] [gcp] fix regions feature changelog entry (#33716)

(cherry picked from commit 97a76bc)

* Update CHANGELOG.next.asciidoc

Co-authored-by: Gabriel Pop <[email protected]>
Co-authored-by: Edoardo Tenani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants