[filebeat][httpjson] - Added bug-fix for duplicate data issue #33213

[ShourieG]

Type of change

• Bug Fix

What does this PR do?

This PR adds a bug-fix for the issue #33213 by getting rid of the if condition which was the culprit, and also putting in
safeguards so the operation remains similar as before and does not break any tests.

Issue: The cursor data was not being updated consistently when chaining with pagination at the root level was present.
This has now been fixed & tests have been added to support the same.

response.split, response.transforms would not work for the initial root response when pagination & chaining were present together. This also has been fixed with this change.

Why is it important?

Fixes a duplicate data bug as reported in the issue #33213

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
  - [] I have made corresponding changes to the documentation
  - [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
  - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

• Code quality & syntax

Related issues

• Closes [Filebeat][httpjson] Value of cursor is not being set in the first call in the chained calls #33213 [Filebeat][Salesforce] Data duplication in Salesforce filebeat module #33212

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[ShourieG]

@efd6 updated pr with the requested changes.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-11-16T07:54:20.907+0000

• Duration: 71 min 25 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2467
Skipped	167
Total	2634

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[efd6]

Can you construct a test that will fail without this change based on the original issue?

[ShourieG]

@efd6 I re-evaluated the fix and saw that we need not mess with the clearInterval() logic. The cursor data was not being updated consistently when chaining with pagination was present and have made changes to fix that, this also fixes any issues we had with the clear interval call. Pagination is avoided for the 1st root level request in the 1st iteration when chaining is present and this is done in a way such that the last_response, last_event & first_event are all properly updated along with any response.transforms or response.split operations. This was not happening initially and it has now been fixed. Added tests to support the same.