Fix loop in filesystemn reporting and debug statement in fsstat #33646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
Team:Elastic-Agent
fearful-symmetry
requested review from
rdner and
cmacknz
and removed request for
a team
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
botelastic
bot
added
needs_team
|
Needs a changelog entry |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
cmacknz
reviewed
Nov 10, 2022
Co-authored-by: Craig MacKenzie <[email protected]>
cmacknz
approved these changes
Nov 10, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* fix loop in filesystem and debug loop in fsstat * add changelog * Update CHANGELOG.next.asciidoc Co-authored-by: Craig MacKenzie <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]> (cherry picked from commit a56c4f7)
fearful-symmetry
added a commit
that referenced
this pull request
Nov 14, 2022
…) (#33648) * fix loop in filesystem and debug loop in fsstat * add changelog * Update CHANGELOG.next.asciidoc Co-authored-by: Craig MacKenzie <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]> (cherry picked from commit a56c4f7) Co-authored-by: Alex K <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* fix loop in filesystem and debug loop in fsstat * add changelog * Update CHANGELOG.next.asciidoc Co-authored-by: Craig MacKenzie <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes two bugs:
system.filesystemmetricset will hard-fail if it encounters a filesystem it can't fetch stats for, instead of merely skipping the given filesystemsystem.fsstathad a bad logging statement.Why is it important?
These are both bugs.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.